From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbdHBUfy (ORCPT ); Wed, 2 Aug 2017 16:35:54 -0400 Received: from smtprelay0110.hostedemail.com ([216.40.44.110]:42175 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752299AbdHBUfx (ORCPT ); Wed, 2 Aug 2017 16:35:53 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2736:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3872:3874:4250:4321:5007:6119:7903:10004:10400:10848:11232:11658:11914:12043:12740:12760:12895:13069:13073:13311:13357:13439:14181:14659:14721:21080:21324:21611:21627:30029:30051:30054:30060:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: cream58_15fb3dc4eff45 X-Filterd-Recvd-Size: 2621 Message-ID: <1501706149.31625.10.camel@perches.com> Subject: Re: [PATCH V2] get_maintainer: Prepare for separate MAINTAINERS files From: Joe Perches To: Linus Torvalds , Randy Dunlap Cc: Andrew Morton , Linux Kernel Mailing List Date: Wed, 02 Aug 2017 13:35:49 -0700 In-Reply-To: References: <1501661042.31625.0.camel@perches.com> <83fbe646-23f4-2098-b907-85aeae211fb6@infradead.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-08-02 at 11:15 -0700, Linus Torvalds wrote: > On Wed, Aug 2, 2017 at 11:06 AM, Randy Dunlap wrote: > > > > IMO, the parse-maintainters.pl (sorting) script makes the need for separate > > MAINTAINERS files much less important since the file can be "fixed" easily > > at any time. > > For me it's not the "fixing". It's the inevitable merge mess, and the > two hundred commits that I have to go through. > > That said, the extra time just to look for MAINTAINERS files makes me > unhappy. It may be just .3s on Joe's machine, but it's presumably much > more when things aren't in the filesystem caches. I (like apparently > Joe) have an SSD so it's not a big deal for me, but.. > > Just having a single MAINTAINERS directory would alleviate that concern. Yeah. Quite a bit. With an i5-6200 and an SSD: Looking for all MAINTAINERS files: Cold cache find: $ time find . -not \( -path ./.git -prune \) -name MAINTAINERS ./drivers/staging/unisys/MAINTAINERS ./MAINTAINERS real 0m3.129s user 0m0.368s sys 0m0.828s Warm cache find: $ time find . -not \( -path ./.git -prune \) -name MAINTAINERS ./drivers/staging/unisys/MAINTAINERS ./MAINTAINERS real 0m0.151s user 0m0.084s sys 0m0.064s vs looking for all files in MAINTAINERS directory Cold cache: $ time find MAINTAINERS.tmp/ | wc -l 1736 real 0m0.037s user 0m0.016s sys 0m0.012s Warm cache: $ time find MAINTAINERS.tmp/ | wc -l 1736 real 0m0.017s user 0m0.012s sys 0m0.008s