Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

Johannes Thumshirn
2017-08-03T07:56:00Z

On Thu, Aug 03, 2017 at 08:24:59AM +0200, Hannes Reinecke wrote:
> > + U32
> > + IOCLogInfo; /*0x10 */
> > + U16
> > + ErrorResponseCount; /*0x14 */
> > + U16
> > + Reserved4; /*0x16 */
> > +} MPI26_NVME_ENCAPSULATED_ERROR_REPLY,
> > + *PTR_MPI26_NVME_ENCAPSULATED_ERROR_REPLY,
> > + Mpi26NVMeEncapsulatedErrorReply_t,
> > + *pMpi26NVMeEncapsulatedErrorReply_t;
> > +
> > +
> > +#endif
> > +
> > +
> Very odd indentation.
> Please reformat to have type and variable on one line.

And use Linux types and no CamelCase and no typedefs (especially not for
pointers), you're not on Windows here.

Thanks,
Johannes

--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850