Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads

Neil Horman
2017-08-29T11:36:15Z

On Tue, Aug 29, 2017 at 12:22:25PM +0200, Wolfram Sang wrote:
>
> > >> So basically the byte count already precedes the data in the dma_buffer,
> > >> then the driver sticks desc->rxbytes in front of this resulting in the
> > >> trace above.
> > >>
> > >> The first patch tackles this.
> > >>
> > >> The second patch in the series adds a sanity check on the byte count
> > >> supplied by the slave device. This might be a nice to have, but is
> > >> probably less critical.
> > >
> > > Both patches look good to me. Seth, Neil, do you agree?
> > >
> >
> > Ping.
> >
> > Not sure what the usual review time is, let me know if this is premature.
>
> I applied both patches to for-next (v4.14) now to get a broader
> audience. for-current (v4.13) might have been also applicable, but I
> don't want to apply the patches there without the driver maintainer
> acks. I hope this works for you.
>

Sorry, I've been on vacation, yes, the patches look good to me

Acked-by: Neil Horman <nhorman@tuxdriver.com>