From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752151AbdHHIbO (ORCPT ); Tue, 8 Aug 2017 04:31:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:51684 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751983AbdHHIbM (ORCPT ); Tue, 8 Aug 2017 04:31:12 -0400 Message-ID: <1502180903.17208.2.camel@suse.com> Subject: Re: [PATCH v2] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter From: Oliver Neukum To: Kai-Heng Feng , gregkh@linuxfoundation.org Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Tue, 08 Aug 2017 10:28:23 +0200 In-Reply-To: <20170808063254.6487-1-kai.heng.feng@canonical.com> References: <20170808063254.6487-1-kai.heng.feng@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 08.08.2017, 14:32 +0800 schrieb Kai-Heng Feng: > Moshi USB to Ethernet Adapter internally uses a Genesys Logic hub to > connect to Realtek r8153. > > The Realtek r8153 ethernet does not work on the internal hub, no-lpm quirk > can make it work. > > Since another r8153 dongle at my hand does not have the issue, so add > the quirk to the hub instead. But in the comment you say you add it to the device! This makes no sense. [..] > + /* Moshi USB to Ethernet Adapter */ > + { USB_DEVICE(0x05e3, 0x0616), .driver_info = USB_QUIRK_NO_LPM }, > + Now is this a hub or a device? If this is a Genesys Logic hub, you need to say that clearly and state that it is an internal hub. Regards Oliver