From: Joe Perches <joe@perches.com>
To: Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, monstr@monstr.eu
Cc: "Sai Krishna Potthuri" <lakshmi.sai.krishna.potthuri@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-iio@vger.kernel.org, "Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Jonathan Cameron" <jic23@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: adc: Fix coding style violations
Date: Tue, 08 Aug 2017 08:52:44 -0700 [thread overview]
Message-ID: <1502207564.2219.35.camel@perches.com> (raw)
In-Reply-To: <d310ac06b13cf803bd3a2a6bcfb92169445f929c.1502193860.git.michal.simek@xilinx.com>
On Tue, 2017-08-08 at 14:04 +0200, Michal Simek wrote:
> From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
[]
> diff --git a/drivers/iio/adc/xilinx-xadc.h b/drivers/iio/adc/xilinx-xadc.h
[]
> @@ -76,7 +76,7 @@ struct xadc_ops {
> int (*setup)(struct platform_device *pdev, struct iio_dev *indio_dev,
> int irq);
> void (*update_alarm)(struct xadc *, unsigned int);
> - unsigned long (*get_dclk_rate)(struct xadc *);
> + unsigned long (*get_dclk_rate)(struct xadc *xadc);
> irqreturn_t (*interrupt_handler)(int, void *);
Doesn't it seem odd to you that the lines above and below
have the same form?
checkpatch is an imperfect tool.
It will always be imperfect.
Please use your eyes and mind too.
next prev parent reply other threads:[~2017-08-08 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 12:04 [PATCH] iio: adc: Fix coding style violations Michal Simek
2017-08-08 15:52 ` Joe Perches [this message]
2017-08-10 6:31 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502207564.2219.35.camel@perches.com \
--to=joe@perches.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=pmeerw@pmeerw.net \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox