From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbdHIAhz (ORCPT ); Tue, 8 Aug 2017 20:37:55 -0400 Received: from smtprelay0133.hostedemail.com ([216.40.44.133]:36309 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752333AbdHIAhy (ORCPT ); Tue, 8 Aug 2017 20:37:54 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:421:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2540:2553:2559:2562:2828:3138:3139:3140:3141:3142:3355:3622:3865:3866:3867:3868:3871:3872:3873:3874:4250:4321:4362:5007:6117:6119:7875:7903:7974:10004:10400:10848:11232:11658:11914:12050:12114:12663:12740:12895:13161:13184:13229:13439:13894:14096:14097:14180:14181:14659:14721:21080:21325:21525:21627:30054:30060:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: sail49_a8e94e7b6f0d X-Filterd-Recvd-Size: 3439 Message-ID: <1502239070.2219.40.camel@perches.com> Subject: Re: [PATCH 4/4] scripts/move_maintainer_sections.bash From: Joe Perches To: Linus Torvalds Cc: Linux Kernel Mailing List , Andrew Morton Date: Tue, 08 Aug 2017 17:37:50 -0700 In-Reply-To: References: <1502125476.2219.28.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-08-08 at 11:33 -0700, Linus Torvalds wrote: > On Mon, Aug 7, 2017 at 10:04 AM, Joe Perches wrote: > > On Sat, 2017-08-05 at 18:45 -0700, Joe Perches wrote: > > > Move MAINTAINERS into a separate directory and reorder it. > > > Separate various blocks of MAINTAINER sections into separate files. > > > > Hey Linus. > > > > If/when you try this out, do please let me know what > > you think. > > Ok, I've applied the preparatory patches, but not run the script. > > Or rather, I ran the script to see what happens, but I'm not going to > push the end result. > > From a quick look at the end result, I note: > > - the arch maintainer split is pointless. It ends up being just one > entry per architecture I think that's just preliminary. Many of the arches have a single maintainer and many of the drivers specific to that arch could/should be moved into the arch_ file. But that doesn't seem easily scriptable. > for x86_64 not even that (because the x86> pattern matched all of > them) What x86_64 section is that? There isn't an arch/x86_64 directory and only 1 combined entry for x86 and x86_64. > - the two arch maintainer lists that end up being bigger is x86 and > arm, but the x86 one picked up a log of misleading ones (not just PCI: > EFI, various random other things too) Yeah, it's imperfect. Suggestions welcomed. > - they all end up having the empty line at the top because of how the > parse-maintainers.pl script works. That's because I was a bit lazy about the output. awk '{ if (NR > 1) { print; } }' would fix it. Also a 00-README type file for the introductory section could be useful. > But *some* of it looks really nice. > > The other thing I note is that the way the patches look, this is going > to be a disaster to merge with any other work - and there really tends > to be a lot of things touching MAINTAINERS. It is going to be messy. Once done it should be easier though. Even today there's a merge conflict (kinda) with -next and the alphabetic reordering movement as one of the sections is duplicated again. (SYNC FILE FRAMEWORK) Collecting the remainder MAINTAINERS patches after an -rc1 and applying them with a quilt like merge might help too if Andrew feels up to it. > I'll have to think about it. > > But at least the infrastructure patches are applied, Thanks.