From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: <sean.wang@mediatek.com>
Cc: <robh+dt@kernel.org>, <matthias.bgg@gmail.com>,
<mark.rutland@arm.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <jamesjj.liao@mediatek.com>,
<henryc.chen@mediatek.com>, <devicetree@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <chenglin.xu@mediatek.com>,
<chen.zhong@mediatek.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380
Date: Wed, 9 Aug 2017 17:22:39 +0800 [thread overview]
Message-ID: <1502270559.6566.14.camel@mtksdaap41> (raw)
In-Reply-To: <0cd2be9a7058bb51fbbc7cc96101cba44fc081f6.1500368529.git.sean.wang@mediatek.com>
On Tue, 2017-07-18 at 17:49 +0800, sean.wang@mediatek.com wrote:
> From: Chenglin Xu <chenglin.xu@mediatek.com>
>
> The MT6380 is a regulator found those boards with MediaTek MT7622 SoC
> It is connected as a slave to the SoC using MediaTek PMIC wrapper which
> is the common interface connecting with Mediatek made various PMICs.
>
> Signed-off-by: Chenglin Xu <chenglin.xu@mediatek.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> drivers/regulator/Kconfig | 9 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/mt6380-regulator.c | 359 +++++++++++++++++++++++++++++
> include/linux/regulator/mt6380-regulator.h | 32 +++
> 4 files changed, 401 insertions(+)
> create mode 100644 drivers/regulator/mt6380-regulator.c
> create mode 100644 include/linux/regulator/mt6380-regulator.h
>
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 48db87d..c46ef9c 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -541,6 +541,15 @@ config REGULATOR_MT6323
> This driver supports the control of different power rails of device
> through regulator interface.
>
> +config REGULATOR_MT6380
> + tristate "MediaTek MT6380 PMIC"
> + depends on MTK_PMIC_WRAP
> + help
> + Say y here to select this option to enable the power regulator of
> + MediaTek MT6380 PMIC.
> + This driver supports the control of different power rails of device
> + through regulator interface.
> +
> config REGULATOR_MT6397
> tristate "MediaTek MT6397 PMIC"
> depends on MFD_MT6397
> diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
> index dc3503f..5148583 100644
> --- a/drivers/regulator/Makefile
> +++ b/drivers/regulator/Makefile
> @@ -70,6 +70,7 @@ obj-$(CONFIG_REGULATOR_MC13892) += mc13892-regulator.o
> obj-$(CONFIG_REGULATOR_MC13XXX_CORE) += mc13xxx-regulator-core.o
> obj-$(CONFIG_REGULATOR_MT6311) += mt6311-regulator.o
> obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o
> +obj-$(CONFIG_REGULATOR_MT6380) += mt6380-regulator.o
> obj-$(CONFIG_REGULATOR_MT6397) += mt6397-regulator.o
> obj-$(CONFIG_REGULATOR_QCOM_RPM) += qcom_rpm-regulator.o
> obj-$(CONFIG_REGULATOR_QCOM_SMD_RPM) += qcom_smd-regulator.o
> diff --git a/drivers/regulator/mt6380-regulator.c b/drivers/regulator/mt6380-regulator.c
> new file mode 100644
> index 0000000..5fca36f
> --- /dev/null
> +++ b/drivers/regulator/mt6380-regulator.c
<...>
> +static struct regulator_ops mt6380_volt_range_ops = {
> + .list_voltage = regulator_list_voltage_linear_range,
> + .map_voltage = regulator_map_voltage_linear_range,
> + .set_voltage_sel = regulator_set_voltage_sel_regmap,
> + .get_voltage_sel = regulator_get_voltage_sel_regmap,
> + .set_voltage_time_sel = regulator_set_voltage_time_sel,
> + .enable = regulator_enable_regmap,
> + .disable = regulator_disable_regmap,
> + .is_enabled = regulator_is_enabled_regmap,
> + .set_mode = mt6380_regulator_set_mode,
> + .get_mode = mt6380_regulator_get_mode,
> +};
> +
> +static struct regulator_ops mt6380_volt_table_ops = {
> + .list_voltage = regulator_list_voltage_table,
> + .map_voltage = regulator_map_voltage_iterate,
> + .set_voltage_sel = regulator_set_voltage_sel_regmap,
> + .get_voltage_sel = regulator_get_voltage_sel_regmap,
> + .set_voltage_time_sel = regulator_set_voltage_time_sel,
> + .enable = regulator_enable_regmap,
> + .disable = regulator_disable_regmap,
> + .is_enabled = regulator_is_enabled_regmap,
> + .set_mode = mt6380_regulator_set_mode,
> + .get_mode = mt6380_regulator_get_mode,
> +};
> +
> +static struct regulator_ops mt6380_volt_fixed_ops = {
this should be const.
Joe.C
next prev parent reply other threads:[~2017-08-09 9:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 9:49 [PATCH v2 0/9] Add PMIC support to MediaTek MT7622 SoC sean.wang
2017-07-18 9:49 ` [PATCH v2 1/9] dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc sean.wang
2017-07-18 16:01 ` Yingjoe Chen
2017-07-19 2:54 ` Sean Wang
2017-07-18 9:49 ` [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator sean.wang
2017-07-24 18:22 ` Rob Herring
2017-08-11 6:13 ` Sean Wang
2017-07-18 9:49 ` [PATCH v2 3/9] regulator: mt6380: Add support for MT6380 sean.wang
2017-07-18 13:31 ` Mark Brown
2017-08-11 3:11 ` Sean Wang
2017-08-09 9:22 ` Yingjoe Chen [this message]
2017-08-11 3:12 ` Sean Wang
2017-07-18 9:49 ` [PATCH v2 4/9] soc: mediatek: pwrap: add pwrap_read32 for reading in 32-bit mode sean.wang
2017-07-18 9:49 ` [PATCH v2 5/9] soc: mediatek: pwrap: add pwrap_write32 for writing " sean.wang
2017-07-18 9:49 ` [PATCH v2 6/9] soc: mediatek: pwrap: update pwrap_init without slave programming sean.wang
2017-07-18 9:49 ` [PATCH v2 7/9] soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap sean.wang
2017-07-18 9:49 ` [PATCH v2 8/9] soc: mediatek: pwrap: add support for MT7622 SoC sean.wang
2017-07-18 9:49 ` [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding style sean.wang
2017-07-18 16:26 ` Yingjoe Chen
2017-07-18 16:31 ` Joe Perches
2017-08-01 16:53 ` [PATCH v2 0/9] Add PMIC support to MediaTek MT7622 SoC Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502270559.6566.14.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=chenglin.xu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=henryc.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).