public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/7] ALSA: intel8x0m: constify snd_pcm_ops structures
Date: Thu, 10 Aug 2017 17:17:36 +0530	[thread overview]
Message-ID: <1502365658-24723-6-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1502365658-24723-1-git-send-email-arvind.yadav.cs@gmail.com>

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 sound/pci/intel8x0m.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/pci/intel8x0m.c b/sound/pci/intel8x0m.c
index 18ff668..2f1b878 100644
--- a/sound/pci/intel8x0m.c
+++ b/sound/pci/intel8x0m.c
@@ -685,7 +685,7 @@ static int snd_intel8x0m_capture_close(struct snd_pcm_substream *substream)
 }
 
 
-static struct snd_pcm_ops snd_intel8x0m_playback_ops = {
+static const struct snd_pcm_ops snd_intel8x0m_playback_ops = {
 	.open =		snd_intel8x0m_playback_open,
 	.close =	snd_intel8x0m_playback_close,
 	.ioctl =	snd_pcm_lib_ioctl,
@@ -696,7 +696,7 @@ static int snd_intel8x0m_capture_close(struct snd_pcm_substream *substream)
 	.pointer =	snd_intel8x0m_pcm_pointer,
 };
 
-static struct snd_pcm_ops snd_intel8x0m_capture_ops = {
+static const struct snd_pcm_ops snd_intel8x0m_capture_ops = {
 	.open =		snd_intel8x0m_capture_open,
 	.close =	snd_intel8x0m_capture_close,
 	.ioctl =	snd_pcm_lib_ioctl,
@@ -710,8 +710,8 @@ static int snd_intel8x0m_capture_close(struct snd_pcm_substream *substream)
 
 struct ich_pcm_table {
 	char *suffix;
-	struct snd_pcm_ops *playback_ops;
-	struct snd_pcm_ops *capture_ops;
+	const struct snd_pcm_ops *playback_ops;
+	const struct snd_pcm_ops *capture_ops;
 	size_t prealloc_size;
 	size_t prealloc_max_size;
 	int ac97_idx;
-- 
1.9.1

  parent reply	other threads:[~2017-08-10 11:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 11:47 [PATCH 0/7] constify pci snd_pcm_ops structures Arvind Yadav
2017-08-10 11:47 ` [PATCH 1/7] ALSA: ali5451: constify " Arvind Yadav
2017-08-10 11:47 ` [PATCH 2/7] ALSA: au88x0: " Arvind Yadav
2017-08-10 11:47 ` [PATCH 3/7] ALSA: echoaudio: " Arvind Yadav
2017-08-10 11:47 ` [PATCH 4/7] ALSA: intel8x0: " Arvind Yadav
2017-08-10 11:47 ` Arvind Yadav [this message]
2017-08-10 11:47 ` [PATCH 6/7] ALSA: sis7019: " Arvind Yadav
2017-08-10 11:47 ` [PATCH 7/7] ALSA: trident: " Arvind Yadav
2017-08-10 15:57 ` [PATCH 0/7] constify pci " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502365658-24723-6-git-send-email-arvind.yadav.cs@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox