public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Bastien Nocera <hadess@hadess.net>, Jonathan Cameron <jic23@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFT][PATCH] iio: hid-sensor-trigger: Fix the race with user space powering up sensors
Date: Sat, 12 Aug 2017 09:04:22 -0700	[thread overview]
Message-ID: <1502553862.20268.49.camel@linux.intel.com> (raw)
In-Reply-To: <1502542703.2326.1.camel@hadess.net>

On Sat, 2017-08-12 at 14:58 +0200, Bastien Nocera wrote:
> On Sat, 2017-08-12 at 13:16 +0100, Jonathan Cameron wrote:
> > 
> > On Fri, 11 Aug 2017 16:04:30 +0200
> > Bastien Nocera <hadess@hadess.net> wrote:
> > 
> > > 
> > > Woot!
> > > 
[...]

> > > > 
> > > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.i
> > > > nt
> > > > el.com>  
> > > Tested-by: Bastien Nocera <hadess@hadess.net>
> > > 
> > > I'm still chasing a couple of bugs in the user-space side of
> > > things
> > > caused by the removal of the timeout.
> > > 
> > > Thanks!
> > Is it worth me sitting on this for a week or so to see if it deals
> > with
> > all the reported issues around this?
> > 
> > Or are you happy that the test set you have is sufficient to verify
> > it?
> I'd rather have it merged ASAP. The fact that it didn't need to sleep
> for 3 seconds allowed me to find a couple of problems in GNOME's use
> of
> this feature, with the sensor showing up before the desktop has
> started. Those will likely be taken care of next week as well.
> 
> I've tested it on a couple of machines, and it's working as expected.
> 
> > 
> > Definitely good to put this one to bed finally! 
> And no one's happier than me in this one. I can concentrate on bugs I
> wrote myself now ;)
I will resubmit patch by adding Testedby and removing [RFT].

Thanks,
Srinivas

      reply	other threads:[~2017-08-12 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 23:24 [RFT][PATCH] iio: hid-sensor-trigger: Fix the race with user space powering up sensors Srinivas Pandruvada
2017-08-11 14:04 ` Bastien Nocera
2017-08-12 12:16   ` Jonathan Cameron
2017-08-12 12:58     ` Bastien Nocera
2017-08-12 16:04       ` Srinivas Pandruvada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502553862.20268.49.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=hadess@hadess.net \
    --cc=hdegoede@redhat.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox