From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbdHLQE0 (ORCPT ); Sat, 12 Aug 2017 12:04:26 -0400 Received: from mga07.intel.com ([134.134.136.100]:7537 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbdHLQEY (ORCPT ); Sat, 12 Aug 2017 12:04:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,363,1498546800"; d="scan'208";a="889320647" Message-ID: <1502553862.20268.49.camel@linux.intel.com> Subject: Re: [RFT][PATCH] iio: hid-sensor-trigger: Fix the race with user space powering up sensors From: Srinivas Pandruvada To: Bastien Nocera , Jonathan Cameron Cc: Hans de Goede , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 12 Aug 2017 09:04:22 -0700 In-Reply-To: <1502542703.2326.1.camel@hadess.net> References: <1502407444-1078-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1502460270.2588.8.camel@hadess.net> <20170812131611.63667d25@archlinux> <1502542703.2326.1.camel@hadess.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-08-12 at 14:58 +0200, Bastien Nocera wrote: > On Sat, 2017-08-12 at 13:16 +0100, Jonathan Cameron wrote: > > > > On Fri, 11 Aug 2017 16:04:30 +0200 > > Bastien Nocera wrote: > > > > > > > > Woot! > > > [...] > > > > > > > > Signed-off-by: Srinivas Pandruvada > > > nt > > > > el.com>   > > > Tested-by: Bastien Nocera > > > > > > I'm still chasing a couple of bugs in the user-space side of > > > things > > > caused by the removal of the timeout. > > > > > > Thanks! > > Is it worth me sitting on this for a week or so to see if it deals > > with > > all the reported issues around this? > > > > Or are you happy that the test set you have is sufficient to verify > > it? > I'd rather have it merged ASAP. The fact that it didn't need to sleep > for 3 seconds allowed me to find a couple of problems in GNOME's use > of > this feature, with the sensor showing up before the desktop has > started. Those will likely be taken care of next week as well. > > I've tested it on a couple of machines, and it's working as expected. > > > > > Definitely good to put this one to bed finally!  > And no one's happier than me in this one. I can concentrate on bugs I > wrote myself now ;) I will resubmit patch by adding Testedby and removing [RFT]. Thanks, Srinivas