From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbdHMNj1 (ORCPT ); Sun, 13 Aug 2017 09:39:27 -0400 Received: from mga02.intel.com ([134.134.136.20]:39921 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbdHMNjV (ORCPT ); Sun, 13 Aug 2017 09:39:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,368,1498546800"; d="scan'208";a="1162161585" Message-ID: <1502631558.15214.2.camel@linux.intel.com> Subject: Re: [PATCH v1 1/2] hyperv: Include linux/types.h to avoid build break From: Andy Shevchenko To: Thomas Gleixner , Ingo Molnar , devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Cc: Vitaly Kuznetsov , "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger Date: Sun, 13 Aug 2017 16:39:18 +0300 In-Reply-To: <20170813133444.23386-1-andriy.shevchenko@linux.intel.com> References: <20170813133444.23386-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-08-13 at 16:34 +0300, Andy Shevchenko wrote: > The commit 2ffd9e33ce4a > >     ("x86/hyper-v: Use hypercall for remote TLB flush") > > introduced a new C-file where uapi/linux/hyperv.h is included first. > > This makes build failed since UAPI headers are heavily dependent to > special > types of variables, e.g. __u8. > >   CC      arch/x86/hyperv/mmu.o > In file included from include/linux/hyperv.h:28:0, >                  from arch/x86/hyperv/mmu.c:3: > include/uapi/linux/hyperv.h:71:2: error: unknown type name ‘__u8’ >   __u8 operation; >   ^~~~ > > Include linux/types.h to the UAPI header like many others do. > Oops, it's because I have an update to this file in my local uuid branch. In any case this is right thing to do independently of uuid.h inclusion. Please, ignore this patch for now, but note the second one is still valid. > Cc: Vitaly Kuznetsov > Cc: K. Y. Srinivasan > Cc: Haiyang Zhang > Cc: Stephen Hemminger > Signed-off-by: Andy Shevchenko > --- >  include/uapi/linux/hyperv.h | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h > index 7560c0aa60e3..aaf32131b556 100644 > --- a/include/uapi/linux/hyperv.h > +++ b/include/uapi/linux/hyperv.h > @@ -25,6 +25,8 @@ >  #ifndef _UAPI_HYPERV_H >  #define _UAPI_HYPERV_H >   > +#include > + >  /* >   * Framework version for util services. >   */ -- Andy Shevchenko Intel Finland Oy