From: Joe Perches <joe@perches.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-crypto@vger.kernel.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks
Date: Mon, 14 Aug 2017 23:44:21 -0700 [thread overview]
Message-ID: <1502779461.8295.32.camel@perches.com> (raw)
In-Reply-To: <1502778412-16255-12-git-send-email-gilad@benyossef.com>
On Tue, 2017-08-15 at 09:26 +0300, Gilad Ben-Yossef wrote:
> Fix wrong indentation and line breaks, including missing tabs,
> breaking lines longer then 80 char or wrongly broken.
[]
> diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c
[]
> - SSI_LOG_ERR("snprintf returned %d . aborting buffer array dump\n", ret);
> + SSI_LOG_ERR
> + ("snprintf returned %d . aborting buffer array dump\n",
> + ret);
This change is quite unpleasant to read.
next prev parent reply other threads:[~2017-08-15 6:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 6:26 [PATCH v3 00/22] staging: ccree: fixes and simplifications Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 01/22] staging: ccree: fix split strings Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 02/22] staging: ccree: kmalloc by sizeof var not type Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 03/22] staging: ccree: Replace kzalloc with devm_kzalloc Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 04/22] staging: ccree: Convert to devm_ioremap_resource for map, unmap Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 05/22] staging: ccree: Use platform_get_irq and devm_request_irq Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 06/22] staging: ccree: simplify resource release on error Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 07/22] staging: ccree: remove unused completion Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 08/22] staging: ccree: remove m32r as supported platform Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 09/22] staging: ccree: Fix format/argument mismatches Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 10/22] staging: ccree: rewrite GET_DMA_BUFFER_TYPE as func Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 11/22] staging: ccree: fix line indentation and breaks Gilad Ben-Yossef
2017-08-15 6:44 ` Joe Perches [this message]
2017-08-16 22:08 ` Greg Kroah-Hartman
2017-08-15 6:26 ` [PATCH v3 12/22] staging: ccree: align box comment correctly Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 13/22] staging: ccree: fix line indentation and breaks Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 14/22] staging: ccree: fix struct init braces Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 15/22] staging: ccree: fix line indentation and breaks Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 16/22] staging: ccree: fix spelling mistakes Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 17/22] staging: ccree: clean up comments Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 18/22] staging: ccree: move over to BIT macro for bit defines Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 19/22] staging: ccree: fix code indent Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 20/22] staging: ccree: replace noop macro with inline Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 21/22] staging: ccree: save ciphertext for CTS IV Gilad Ben-Yossef
2017-08-15 6:26 ` [PATCH v3 22/22] staging: ccree: remove BUG macro usage Gilad Ben-Yossef
2017-08-16 22:12 ` [PATCH v3 00/22] staging: ccree: fixes and simplifications Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502779461.8295.32.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofir.drang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox