* [PATCH][V2] IB/hns: fix memory leak on ah on error return path
@ 2017-08-08 17:41 Colin King
[not found] ` <52e486f3-4cca-d31c-812e-4027d98b867b@huawei.com>
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-08-08 17:41 UTC (permalink / raw)
To: Lijun Ou, Wei Hu, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
When dmac is NULL, ah is not being freed on the error return path. Fix
this by kfree'ing it.
Detected by CoverityScan, CID#1452636 ("Resource Leak")
Fixes: d8966fcd4c25 ("IB/core: Use rdma_ah_attr accessor functions")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/hns/hns_roce_ah.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_ah.c b/drivers/infiniband/hw/hns/hns_roce_ah.c
index f78a733a63ec..d545302b8ef8 100644
--- a/drivers/infiniband/hw/hns/hns_roce_ah.c
+++ b/drivers/infiniband/hw/hns/hns_roce_ah.c
@@ -64,8 +64,10 @@ struct ib_ah *hns_roce_create_ah(struct ib_pd *ibpd,
} else {
u8 *dmac = rdma_ah_retrieve_dmac(ah_attr);
- if (!dmac)
+ if (!dmac) {
+ kfree(ah);
return ERR_PTR(-EINVAL);
+ }
memcpy(ah->av.mac, dmac, ETH_ALEN);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <52e486f3-4cca-d31c-812e-4027d98b867b@huawei.com>]
* Re: [PATCH][V2] IB/hns: fix memory leak on ah on error return path [not found] ` <52e486f3-4cca-d31c-812e-4027d98b867b@huawei.com> @ 2017-08-16 15:31 ` Doug Ledford 0 siblings, 0 replies; 2+ messages in thread From: Doug Ledford @ 2017-08-16 15:31 UTC (permalink / raw) To: oulijun, Colin King, Wei Hu, Sean Hefty, Hal Rosenstock, linux-rdma Cc: kernel-janitors, linux-kernel On Fri, 2017-08-11 at 09:45 +0800, oulijun wrote: > 在 2017/8/9 1:41, Colin King 写道: > > From: Colin Ian King <colin.king@canonical.com> > > > > When dmac is NULL, ah is not being freed on the error return path. > > Fix > > this by kfree'ing it. > > > > Detected by CoverityScan, CID#1452636 ("Resource Leak") > > > > Fixes: d8966fcd4c25 ("IB/core: Use rdma_ah_attr accessor > > functions") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/infiniband/hw/hns/hns_roce_ah.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/hw/hns/hns_roce_ah.c > > b/drivers/infiniband/hw/hns/hns_roce_ah.c > > index f78a733a63ec..d545302b8ef8 100644 > > --- a/drivers/infiniband/hw/hns/hns_roce_ah.c > > +++ b/drivers/infiniband/hw/hns/hns_roce_ah.c > > @@ -64,8 +64,10 @@ struct ib_ah *hns_roce_create_ah(struct ib_pd > > *ibpd, > > } else { > > u8 *dmac = rdma_ah_retrieve_dmac(ah_attr); > > > > - if (!dmac) > > + if (!dmac) { > > + kfree(ah); > > return ERR_PTR(-EINVAL); > > + } > > memcpy(ah->av.mac, dmac, ETH_ALEN); > > } > > > > Thank you for reviewing and fixing Thanks, patch applied to -rc. -- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-16 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08 17:41 [PATCH][V2] IB/hns: fix memory leak on ah on error return path Colin King
[not found] ` <52e486f3-4cca-d31c-812e-4027d98b867b@huawei.com>
2017-08-16 15:31 ` Doug Ledford
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox