From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359AbdHQSn7 (ORCPT ); Thu, 17 Aug 2017 14:43:59 -0400 Received: from mout.gmx.net ([212.227.17.22]:61371 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbdHQSn5 (ORCPT ); Thu, 17 Aug 2017 14:43:57 -0400 Message-ID: <1502995417.16063.0.camel@gmx.de> Subject: Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers during cpu offline From: Mike Galbraith To: Sebastian Andrzej Siewior Cc: Thomas Gleixner , LKML , linux-rt-users , Steven Rostedt Date: Thu, 17 Aug 2017 20:43:37 +0200 In-Reply-To: <20170817171720.jz2ok332bpxcjzme@linutronix.de> References: <20170804173823.lzuhnejlnxczr2lj@linutronix.de> <1501913583.7917.42.camel@gmx.de> <1501945043.5473.31.camel@gmx.de> <20170807073350.nwytftryfp34mrwi@linutronix.de> <1502094121.5568.22.camel@gmx.de> <1502186459.8042.31.camel@gmx.de> <1502438116.16425.18.camel@gmx.de> <1502439312.16425.19.camel@gmx.de> <1502697588.12319.199.camel@gmx.de> <20170817165041.3agf2btidfdcspiq@linutronix.de> <20170817171720.jz2ok332bpxcjzme@linutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:delMLvI1+GeYW67XlnOmaBLPGJLynu6CB4MxtBx1izioB/ewQuY m0cMxeJmrbdL5DmpnR9Cir1HTMT4adb3m/Purg2BiPJOY/KweTTDtSeVXLz+DAdDtbw9Nyk r0WbGt+d361GKqVLs/MrQ4JGSAjaR6+x1EiDGaLtRd/WeDBB++yEdr+BAx5ojcatieepdEH IzgmNsINERbeLB6wyiHYA== X-UI-Out-Filterresults: notjunk:1;V01:K0:WkZ+HT6SNZs=:D85Omxl6bl2rlNPQmQxi/2 VDeO8Y1YwWnwWXRy3dfuf5w8IzOI8729FtpgGJenGKjs/j9OnezyWiKKig9HEXMSmOmDHNXJV 1Yb8SQS/SJDeOsqkmIHYNTcMRwGNGT2fY6Wdi6hdb1ce48+yvBOhO2WvO8cviRrYisLfmfCH4 W1QYTvDFQOlRLAdkee+jG0GvMzpTzRNu8NEjIewXHEWWtfwCMbKfEn3wMATn03saI3g1abBS0 6ElEYoTM1R2y5oERHUpDnJkFgJYc/UfdgRze4fVNGHhkg9vadwsIrWm1PXFWf7ufdR8cdYQAF /caHjGXwaCndBn+y6sRNNQpT4aSN4oaPgxqu4L+HibYXxXXuUu4WBPYjUUH6J3texm+V9TryP uQU1WHNp/OOlV551jRDNsnb/du664fN+ljW9P3O6+LYCqDAcpmRcvULWs+S1F/Xv5HYiAJPxS TSCtiXdBRSmubfKZ8tS/B6JW/a5oyz8iGVLpDiTs8vpse+NVXnrOjwr1e58ulU256VmNGSuSi T/TR1YehyCVsVdmE/V0jx7jPHc6ml3ej5LgEdoqNoEbuDMgmGBpoADuCox6DYq3gbnCqI7F0l zqtYLSKt2uadBecuCeIxY4ywgncJzw0q23XVa7AHywlvzaVJgc8yzI//YdDxvt+p3UGDU7EBn SrQP+G/KW1e48WKpTGGpEdF3Q5svdWLY9tyf9tqPgbnW8CzCejQX0LL+yKeqCzfs2XF2CVjls x1/ultTzrLRHAHFQQy4YkyHQni5j4l+ev/Gh4e9EkuuDjdQKvu7KyO47CilgLOcuh4tMqWkTP 4tSIjYxTrwWhasErJcdmbFqnnCKtKPeTF7iYPe99mtQo+X7K3I= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-08-17 at 19:17 +0200, Sebastian Andrzej Siewior wrote: > On 2017-08-17 18:50:42 [+0200], To Mike Galbraith wrote: > > __remove_hrtimer() shouldn't be required because it has been done > > already. It should be enough to just list_splice() one list to the > > other and raise the softirq afterwards. > > Mike, can you check this please: Done, works. > diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c > index 55839ff2bba6..4b9264e0d363 100644 > --- a/kernel/time/hrtimer.c > +++ b/kernel/time/hrtimer.c > @@ -1802,6 +1802,11 @@ static void migrate_hrtimer_list(struct hrtimer_clock_base *old_base, > */ > enqueue_hrtimer(timer, new_base); > } > +#ifdef CONFIG_PREEMPT_RT_BASE > + list_splice_tail(&old_base->expired, &new_base->expired); > + if (!list_empty(&new_base->expired)) > + raise_softirq_irqoff(HRTIMER_SOFTIRQ); > +#endif > } > > int hrtimers_dead_cpu(unsigned int scpu)