* [PATCH] cxgb4: Remove some dead code
@ 2017-06-10 9:19 Christophe JAILLET
2017-06-10 12:30 ` Steve Wise
0 siblings, 1 reply; 3+ messages in thread
From: Christophe JAILLET @ 2017-06-10 9:19 UTC (permalink / raw)
To: swise, dledford, sean.hefty, hal.rosenstock
Cc: linux-rdma, linux-kernel, kernel-janitors, Christophe JAILLET
This 'BUG_ON(!ep)' can never trigger because we have:
if (!ep)
return 0;
just a few lines above. So it can be removed safely.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/infiniband/hw/cxgb4/cm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 2f1136bf7b1f..815d7dfbdfb1 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2879,7 +2879,6 @@ static int close_con_rpl(struct c4iw_dev *dev, struct sk_buff *skb)
return 0;
pr_debug("%s ep %p tid %u\n", __func__, ep, ep->hwtid);
- BUG_ON(!ep);
/* The cm_id may be null if we failed to connect */
mutex_lock(&ep->com.mutex);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] cxgb4: Remove some dead code
2017-06-10 9:19 [PATCH] cxgb4: Remove some dead code Christophe JAILLET
@ 2017-06-10 12:30 ` Steve Wise
2017-08-17 22:06 ` Doug Ledford
0 siblings, 1 reply; 3+ messages in thread
From: Steve Wise @ 2017-06-10 12:30 UTC (permalink / raw)
To: 'Christophe JAILLET', dledford, sean.hefty,
hal.rosenstock
Cc: linux-rdma, linux-kernel, kernel-janitors
Acked-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cxgb4: Remove some dead code
2017-06-10 12:30 ` Steve Wise
@ 2017-08-17 22:06 ` Doug Ledford
0 siblings, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2017-08-17 22:06 UTC (permalink / raw)
To: Steve Wise, 'Christophe JAILLET', sean.hefty,
hal.rosenstock
Cc: linux-rdma, linux-kernel, kernel-janitors
On Sat, 2017-06-10 at 07:30 -0500, Steve Wise wrote:
> Acked-by: Steve Wise <swise@opengridcomputing.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-17 22:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-10 9:19 [PATCH] cxgb4: Remove some dead code Christophe JAILLET
2017-06-10 12:30 ` Steve Wise
2017-08-17 22:06 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox