From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbdHULpr convert rfc822-to-8bit (ORCPT ); Mon, 21 Aug 2017 07:45:47 -0400 Received: from mout.gmx.net ([212.227.17.20]:65199 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753902AbdHULpn (ORCPT ); Mon, 21 Aug 2017 07:45:43 -0400 Message-ID: <1503315910.25589.166.camel@gmx.de> Subject: Re: [rfc patch] sched/topology: fix domain reconstruction memory leakage From: Mike Galbraith To: Peter Zijlstra Cc: Ingo Molnar , LKML Date: Mon, 21 Aug 2017 13:45:10 +0200 In-Reply-To: <20170821081615.cpjmas4x5p7pcrbh@hirez.programming.kicks-ass.net> References: <1503123049.5112.49.camel@gmx.de> <20170821081615.cpjmas4x5p7pcrbh@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K0:LBubQS/E56CTNJy0icmdVf07U3VsbiG7Yh0+o08VFnHE58mHEEO 7IK0QlTxXTNPcPEuYa81q5SZDG4BocpKCqPlXhopyBTXx/GgWbYGHa5CIpLTMjRjDty0hko DwdZ86shPKPR967X4wpcVnz9bUI7oRuxyXvKi0kUuzovXKSJ2887GJifdrXlm/c8s2IAbpa M2ifs/6e4Mo3kgOPxsRdw== X-UI-Out-Filterresults: notjunk:1;V01:K0:3sJbqM8QsnM=:t/dhoiqlQAXdHD5XEOsG6P OZOc8GGuI2zOigBicPLT91P6jqm7QMJWBnXfFkJlZHnNwp984juzwnvaKVz8D/PRpRoKrRsma c8l6ZUzZyYxMCJ0xtj++7weNR6WZA8xTUqciHJQZq1oC1BZol6cIYCrvahcquLHXw9cMT7Pk9 BIicqOwO10X32GVNFvvHh4OmsPdbXiSjFTSRF+9P9rvHSPIPPaGx6ZK71owmAdNXETcZkTdiZ wTXK43GEIr45VB60fmPzHvcdojcbeY1jQ/BFbK00EoDBLz+jhYKqHabXL5IagMTwHlAJH+Wn9 wohyc5uT69xxyeIzt3Vml4t16p0c2fbPiwTDMGddYFtpc+gSjDLXI8FTvSD7Fv2/IqdofJEhu pqqWlDD011eXtVTnmGEKIWhuyjs7yeOAikQXHqpBB5ezcTHCd4R0kbZcpSPgjbWLNqTzUc2xt FSlj/HmgJUqSUO/R/z8Qzn/9+4z46RJ5dfULBz92sHvDfznjPedprhsL8oTYWUmpIxHgh3ayn YuGqILDrjkoBV/Z1DwcdkPcWv9h1w5ordsJiQl73GbdSD8hfitMbDJhiMlb7yYlaGbkjLOkqd g2IEZHucXTX9dYjoa9uLa/sbwnrL3yxTeUGxkvlovdANZ6Vk4ZhTVCpwRw2mCRhjLVSYSP+ke jIJy47xkDn/h8c1THK13wMY6GOJwYjvZmj41MAn2e+f4lUGGcz3NvxCIjVTPl4zFvEf9FOf2l VH6bjZD2U4iFume6/tUR6DCXiLHD5s+ncSEA7ayff+a7CarAld2eogO+cdsWYEX1XJmZjjEMW Nq8trGmqxtv57NJ7eA/doFXXjboP8WgGX5Gj79Efzsv6fU46rw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-08-21 at 10:16 +0200, Peter Zijlstra wrote: > On Sat, Aug 19, 2017 at 08:10:49AM +0200, Mike Galbraith wrote: > > Greetings, > > > > While beating on cpu hotplug with the shiny new topology fixes > > backported, my memory poor 8 socket box fairly quickly leaked itself to > > death, 0c0e776a9b0f being the culprit.  With the below applied, box > > took a severe beating overnight without a whimper. > > > > I'm wondering (ergo rfc) if free_sched_groups() shouldn't be renamed to > > put_sched_groups() instead, with overlapping domains taking a group > > reference reference as well so they can put both sg/sgc rather than put > > one free the other.  Those places that want an explicit free can pass > > free to only explicitly free sg (or use two functions).  Minimalist > > approach works (minus signs, yay), but could perhaps use some "pretty". > > > > sched/topology: fix domain reconstruction memory leakage > > I was sitting on this one: > > https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=sched/core&id=c63d18dd6ea59eec5cba857835f788943ff9f0d5 > > is that the same? If that doesn't muck up the other places that were doing explicit sd free without putting sgc, cool (I still like rename.. but then me and pretty don't seem to get along all that well, so whatever works;). -Mike