From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043AbdHUPmG (ORCPT ); Mon, 21 Aug 2017 11:42:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:59900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753951AbdHUPmB (ORCPT ); Mon, 21 Aug 2017 11:42:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C3452170C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org From: Masami Hiramatsu To: Steven Rostedt , Ingo Molnar Cc: Frederic Weisbecker , systemtap@sourceware.org, linux-kernel@vger.kernel.org, Alban Crequy , Alban Crequy , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S . Miller" Subject: [RFC PATCH -tip 1/2] trace: kprobes: Show sum of probe/retprobe nmissed count Date: Tue, 22 Aug 2017 00:41:11 +0900 Message-Id: <150333006163.7343.4285813039620422255.stgit@devbox> X-Mailer: git-send-email 2.13.5 In-Reply-To: <150332999488.7343.4502723000922707699.stgit@devbox> References: <150332999488.7343.4502723000922707699.stgit@devbox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Show sum of probe and retprobe nmissed count in kprobe_profile, since retprobe can be missed even if the kprobe itself succeeeded. This explains user why their return probe didn't hit sometimes. Signed-off-by: Masami Hiramatsu Tested-by: Alban Crequy --- kernel/trace/trace_kprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index c9b5aa10fbf9..fe1bd541216c 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -928,7 +928,7 @@ static int probes_profile_seq_show(struct seq_file *m, void *v) seq_printf(m, " %-44s %15lu %15lu\n", trace_event_name(&tk->tp.call), trace_kprobe_nhit(tk), - tk->rp.kp.nmissed); + tk->rp.kp.nmissed + tk->rp.nmissed); return 0; }