From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755953AbbLGJlb (ORCPT ); Mon, 7 Dec 2015 04:41:31 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:57065 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261AbbLGJl1 (ORCPT ); Mon, 7 Dec 2015 04:41:27 -0500 From: Arnd Bergmann To: "Yankejian (Hackim Yim)" Cc: davem@davemloft.net, fengguang.wu@intel.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, catalin.marinas@arm.com, will.deacon@arm.com, salil.mehta@huawei.com, Yisen.Zhuang@huawei.com, liguozhu@huawei.com, lisheng011@huawei.com, huangdaode@hisilicon.com, xuwei5@hisilicon.com, haifeng.wei@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: arRe: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) Date: Mon, 07 Dec 2015 10:40:04 +0100 Message-ID: <1503684.BNZUVaD74W@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <566531C5.4050208@huawei.com> References: <1449295856-31068-1-git-send-email-yankejian@huawei.com> <23027215.8RIhViTVaB@wuerfel> <566531C5.4050208@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:yR4BvB+QJlKDHPixXnakK92396xVSteZubCqf7YWaZzJhUMJf6n r3lsPgJ4lUGDg7QtIoPK3wqzv4TVNLhFTDhR92BVnZk55/NHa2OcnRj7zmgB6U0N9+LiDjm 6JzBP2ZGOlIfwVY7//41hIzTMbtyjkO5gzpfgEku593hII6pqQYYtmzn6PJNtstSCWUEZdv jximAHXUpHYNUqmOYvUeA== X-UI-Out-Filterresults: notjunk:1;V01:K0:KR/9eFRF27c=:FNuBhxG9dapzlaYedsTLzL mwocp2XvyW85To+igNJleeRVZ4qiBmBxPQjUrZ7t630nLb74O5X4dSuFTiZ0fPwhRAIsBVf5K 0YDdR+4BMt3uufX4Ig+Kd/blW8vGVsFK76/Vzb+0ZGSE+iE/GsTmXuqpV18JGfjkPqEvXzqhV O+dwu9GQyyIKcCDXachXKBXq4i+L9vNmTiSr2+CyrJubri8vQHbjt5YM7UzuyUzMZqVtuIPJf /UPbM0CZLTX8tFfwTCeZppgSdEdtYCwFat+U3mz4sx5vUppBJo9mbGW4nivAhRx5LQe5p2mWB kTWS3xXcGPw3tfTVogIR8xWL+G+v5c0E3kO19a+zMNblI9u2wVE3NNrsfVww+V/P5cQx74adC WHjJZXkA62L7qrw1Sm/VQeRq83wMU8RwuUX3PWkJpTFywh3y9e4x5/GaB7v7hEAptNzjxoUyn qzuSd3/HrPY2zTUW7m+IAurFYIi1KGX+sN9yQ77u6qN8ByZ1wqIk9HFpVe1D+3HCSdINAbkFF eNf9Q7SB/IMwpVeysjonGOpJFOeMLCvNDGzeB9yq/kI0BQigcRD21vJs69OIBz0RaoruB7Aka QGnDNL8IBJN2Y40Mlnxu2zySY9ufsnbNbaz23jaUA4gqLa/5Yr3ejN9McuNIZeTVab/mx7+uu kcHUB+D3axU0WBiUsEEgVuYHwur09rqSI+Tqo4JBAPcBsetlYYk09nQeRV4GQNu34PxB8lA0c mlODl0+sH1ISk18R Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 07 December 2015 15:14:13 Yankejian wrote: > On 2015/12/6 6:19, Arnd Bergmann wrote: > > On Saturday 05 December 2015 14:10:56 yankejian wrote: > >> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt > >> index 80411b2..ecacfa4 100644 > >> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt > >> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt > >> @@ -4,8 +4,6 @@ Required properties: > >> - compatible: should be "hisilicon,hns-dsaf-v1" or "hisilicon,hns-dsaf-v2". > >> "hisilicon,hns-dsaf-v1" is for hip05. > >> "hisilicon,hns-dsaf-v2" is for Hi1610 and Hi1612. > >> -- dsa-name: dsa fabric name who provide this interface. > >> - should be "dsafX", X is the dsaf id. > >> - mode: dsa fabric mode string. only support one of dsaf modes like these: > >> "2port-64vf", > >> "6port-16rss", > >> @@ -26,9 +24,8 @@ Required properties: > >> > >> Example: > >> > >> -dsa: dsa@c7000000 { > >> +dsaf0: dsa@c7000000 { > >> compatible = "hisilicon,hns-dsaf-v1"; > >> - dsa_name = "dsaf0"; > >> mode = "6port-16rss"; > >> interrupt-parent = <&mbigen_dsa>; > >> reg = <0x0 0xC0000000 0x0 0x420000 > >> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt > >> index 41d19be..e6a9d1c 100644 > >> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt > >> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt > >> @@ -4,8 +4,9 @@ Required properties: > >> - compatible: "hisilicon,hns-nic-v1" or "hisilicon,hns-nic-v2". > >> "hisilicon,hns-nic-v1" is for hip05. > >> "hisilicon,hns-nic-v2" is for Hi1610 and Hi1612. > >> -- ae-name: accelerator name who provides this interface, > >> - is simply a name referring to the name of name in the accelerator node. > >> +- ae-handle: accelerator engine handle for hns, > >> + specifies a reference to the associating hardware driver node. > >> + see Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt > >> - port-id: is the index of port provided by DSAF (the accelerator). DSAF can > >> connect to 8 PHYs. Port 0 to 1 are both used for adminstration purpose. They > >> are called debug ports. > >> @@ -41,7 +42,7 @@ Example: > >> > >> > > This looks like an incompatible change, as you add and remove > > required properties. Is there a way to support both the old and > > the new style? > > > > Arnd > > > > . > > Hi Arnd, > Thanks for your suggestions. it must be set the same strings in dsaf node and every enet node before. > it seems inappropriate. as Rob Herring 's suggestions, that would solve associating > enet with a particular dsaf. so we discus the solution with Yisen Zhuang . > we decide to use the new way instead of the old one. I agree the new form looks better than the original way, but I'm worried about the migration path. You don't explain in the patch description how you want to ensure that nothing breaks for existing systems. We generally try to avoid doing incompatible changes altogether and prefer to keep backwards compatibility, unless we can prove that no other systems exist that would get impacted by the change. Are you sure that nobody ships a DTB file for this hardware with their firmware that would now require an incompatible update which in turn breaks old kernels? Are you sure that there is no hardware using the same dsa hardware with out-of-tree dts files that need to make the same change but might not be aware of the change? Arnd