From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Yurii Pavlenko <pyldev@gmail.com>
Cc: gregkh@linuxfoundation.org, pkshih@realtek.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging rtlwifi efuse fix up a warning kzalloc
Date: Sat, 26 Aug 2017 08:26:35 -0700 [thread overview]
Message-ID: <1503761195.12569.43.camel@perches.com> (raw)
In-Reply-To: <2ba8d35d-44e8-0509-469b-5564efe64e76@lwfinger.net>
On Sat, 2017-08-26 at 09:48 -0500, Larry Finger wrote:
> I will NACK every
> patch that tries to force code that I maintain to use kcalloc over kzalloc.
Your choice.
The concept behind the kzalloc with multiply vs kcalloc
is protection against multiplication overflow.
It's unlikely to solve any real problem with a
sizeof(foo) * small known number of entries.
It does have application when number of entries is
a user specified value.
next prev parent reply other threads:[~2017-08-26 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-26 13:01 [PATCH] Staging rtlwifi efuse fix up a warning kzalloc Yurii Pavlenko
2017-08-26 14:48 ` Larry Finger
2017-08-26 15:26 ` Joe Perches [this message]
2017-08-28 8:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503761195.12569.43.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=pyldev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox