From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760918AbcAMNzw (ORCPT ); Wed, 13 Jan 2016 08:55:52 -0500 Received: from smtp03.udag.de ([62.146.106.29]:39347 "EHLO smtp03.udag.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755806AbcAMNzt (ORCPT ); Wed, 13 Jan 2016 08:55:49 -0500 Date: Wed, 13 Jan 2016 14:55:47 +0100 (CET) From: Karol Herbst Reply-To: Karol Herbst To: airlied , Arnd Bergmann , dri-devel Cc: bskeggs , linux-kernel , linux-arm-kernel Message-ID: <1503925101.39877.1452693347204.JavaMail.open-xchange@www.ud-mail.de> In-Reply-To: <3968390.Pvmnq3v7oC@wuerfel> References: <3968390.Pvmnq3v7oC@wuerfel> Subject: Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.2-Rev44 X-Originating-Client: open-xchange-appsuite Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Arnd Bergmann hat am 13. Januar 2016 um 14:48 geschrieben: > > The new debugfs initialization code fails to build when CONFIG_DEBUG_FS > is disabled: > > In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0: > drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init': > drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted > nouveau_debugfs_init(struct nouveau_drm *) > > This fixes the prototypes so we can build it again. > thanks for this. I already send a patch to the nouveau ML here: http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html but I guess I should mail to the kernel list directly next time. > Signed-off-by: Arnd Bergmann > Fixes: b126a200e9db ("drm/nouveau/debugfs: we need a ctrl object for debugfs") > --- > This broke when the nouveau patches got merged into drm-next on Monday. > Found on ARM randconfig builds. > > diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.h > b/drivers/gpu/drm/nouveau/nouveau_debugfs.h > index 52c7161297d7..b8c03ff5bf05 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.h > +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.h > @@ -34,13 +34,13 @@ nouveau_drm_debugfs_cleanup(struct drm_minor *minor) > } > > static inline int > -nouveau_debugfs_init(struct nouveau_drm *) > +nouveau_debugfs_init(struct nouveau_drm *drm) > { > return 0; > } > > static inline void > -nouveau_debugfs_fini(struct nouveau_drm *) > +nouveau_debugfs_fini(struct nouveau_drm *drm) > { > } >