From: Ritesh Harjani <riteshh@codeaurora.org>
To: ulf.hansson@linaro.org, adrian.hunter@intel.com
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
stummala@codeaurora.org, asutoshd@codeaurora.org,
Ritesh Harjani <riteshh@codeaurora.org>
Subject: [RFC 4/4] mmc: sdhci-msm: Handle unexpected interrupt case on enabling legacy IRQs on CQE halt
Date: Wed, 30 Aug 2017 18:34:11 +0530 [thread overview]
Message-ID: <1504098251-27739-5-git-send-email-riteshh@codeaurora.org> (raw)
In-Reply-To: <1504098251-27739-1-git-send-email-riteshh@codeaurora.org>
There is a case when enabling the legacy IRQs and halting CQE is
resuling into a command response interrupt without any command in
progress. This patch handles such case here.
Error signature without this patch:-
mmc0: Got command interrupt 0x00000001 even though no command operation
was in progress.
Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org>
---
drivers/mmc/host/sdhci-msm.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index baa3409..8fdc2c0 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -1124,10 +1124,21 @@ void sdhci_msm_cqe_enable(struct mmc_host *mmc)
void sdhci_msm_cqe_disable(struct mmc_host *mmc, bool recovery)
{
struct sdhci_host *host = mmc_priv(mmc);
+ unsigned long flags;
+ u32 ctrl;
if (host->flags & SDHCI_USE_64_BIT_DMA)
host->desc_sz = 16;
+ spin_lock_irqsave(&host->lock, flags);
+
+ ctrl = sdhci_readl(host, SDHCI_INT_ENABLE);
+ ctrl |= SDHCI_INT_RESPONSE;
+ sdhci_writel(host, ctrl, SDHCI_INT_ENABLE);
+ sdhci_writel(host, SDHCI_INT_RESPONSE, SDHCI_INT_STATUS);
+
+ spin_unlock_irqrestore(&host->lock, flags);
+
sdhci_cqe_disable(mmc, recovery);
}
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-08-30 13:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 13:04 [RFC 0/4] mmc: sdhci-msm: Add CQE support for sdhci-msm Ritesh Harjani
2017-08-30 13:04 ` [RFC 1/4] mmc: cqhci: Move CQHCI_ENABLE before setting TDLBA/TDLBAU Ritesh Harjani
2017-08-31 6:01 ` Adrian Hunter
2017-09-02 5:09 ` Ritesh Harjani
2017-08-30 13:04 ` [RFC 2/4] mmc: sdhci-msm: Add CQHCI support for sdhci-msm Ritesh Harjani
2017-08-31 7:25 ` Adrian Hunter
2017-09-02 5:10 ` Ritesh Harjani
2017-08-30 13:04 ` [RFC 3/4] mmc: sdhci-msm: Change the desc_sz on cqe_enable/disable Ritesh Harjani
2017-08-31 6:42 ` Adrian Hunter
2017-09-02 5:12 ` Ritesh Harjani
2017-08-30 13:04 ` Ritesh Harjani [this message]
2017-08-31 7:35 ` [RFC 4/4] mmc: sdhci-msm: Handle unexpected interrupt case on enabling legacy IRQs on CQE halt Adrian Hunter
2017-09-02 5:13 ` Ritesh Harjani
2017-08-31 8:39 ` [RFC 0/4] mmc: sdhci-msm: Add CQE support for sdhci-msm Adrian Hunter
2017-09-02 5:16 ` Ritesh Harjani
-- strict thread matches above, loose matches on Subject: below --
2017-08-30 12:59 Ritesh Harjani
2017-08-30 12:59 ` [RFC 4/4] mmc: sdhci-msm: Handle unexpected interrupt case on enabling legacy IRQs on CQE halt Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504098251-27739-5-git-send-email-riteshh@codeaurora.org \
--to=riteshh@codeaurora.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox