From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbdH3OA6 (ORCPT ); Wed, 30 Aug 2017 10:00:58 -0400 Received: from mga06.intel.com ([134.134.136.31]:18028 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbdH3OA5 (ORCPT ); Wed, 30 Aug 2017 10:00:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,448,1498546800"; d="scan'208";a="143692880" From: "Bernat, Yehezkel" To: "mika.westerberg@linux.intel.com" , "gregkh@linuxfoundation.org" CC: "andreas.noever@gmail.com" , "andriy.shevchenko@linux.intel.com" , "Jamet, Michael" , "lukas@wunner.de" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] thunderbolt: Remove superfluous check Thread-Topic: [PATCH 1/3] thunderbolt: Remove superfluous check Thread-Index: AQHTFYYG1j0KaT7jlUm0Fvh/GK87qaKE/d0AgBNIqICAAaAJAIADHzUA Date: Wed, 30 Aug 2017 14:00:53 +0000 Message-ID: <1504101658.2677.25.camel@intel.com> References: <29cf6caa-07a9-9c52-bd8c-6634749f99ca@intel.com> <20170815070228.GG2369@lahna.fi.intel.com> <20170827133127.GC2980@lahna.fi.intel.com> <20170828142030.GA23672@kroah.com> In-Reply-To: <20170828142030.GA23672@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.18.5.2-0ubuntu3.2 authentication-results: spf=none (sender IP is ) smtp.mailfrom=yehezkel.bernat@intel.com; x-originating-ip: [134.191.232.68] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN4PR11MB0883;6:W2z/ceKm24Ypy11+Tvy8w8NCHL2aFP/oEHu91ZXjDmNo52GdvMaEbO24/zMcboGjfwHrusIDIuLw96bmh88PoZy7m10N0PqmtKRpcwM7auzWLFFcsF+m7clXlsvZi3iIk5cTmTHiuyTvdhjplsX0ub2B+zJsYAK1CnfvivHDlQlui9G+9ygMhQZLUMW/b4w6zB4B81Mqa7dquyrmXPLwz5uVdV46pR6VX2vLnultdcsyjbXm5lYL4eAjRfXfLZRablCpxr7d849g4YlIExW7gXSc6YmxLa/iQGsYyRXfRAqVF46uV/mngkqzbFVtW5T7NOwFrC6d4HV1dQiBoICBpQ==;5:uCGLGnYkiheHX8QLAyuWhA8fDM8Hvp+5a/ueBJYH4mvan56XyBlECW32carhbzgYF+pdnubMdNVz8fJJpkaXMK35b+F9UMVr2xwwGmn2AdVBgK+SiCUIbNkqs5NeEH4hSz2d7WXKEW5JSUdLRTJCyg==;24:5Bi2IFvzFObAMMsoukAjQir0IrDIgzI90sCrRDlbOWu4XzoWWp9yD+QrmJrbZ/XlOzRyEN+VoN7OGFvhh304hs/jNufPqaMw7LTJYsY2Nzc=;7:OlzGgXiegFX4v/VwRjbFAZt0Yhd19Nk9z8HtpPQVDesqGbxcvijbiM+9b8w26NoveilZZONJDdXUf+bd38X49ihZF5T90DH5xOclOfHfxBKvOt36RmtV2D/Zu8Ov6BXYI0nK+etj6K57+juyRcx5cNAmAd355fFZaIsabkYDkpHJeodWHomrqgtVtAXD//LQ9UySKLdWuKfGc3yCJxaTMN+Jz2dnOTAA9Himlb3aBr0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-office365-filtering-correlation-id: b945b501-dda9-45f4-cb51-08d4efaf8778 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN4PR11MB0883; x-ms-traffictypediagnostic: BN4PR11MB0883: x-exchange-antispam-report-test: UriScan:(192374486261705)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN4PR11MB0883;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN4PR11MB0883; x-forefront-prvs: 041517DFAB x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39830400002)(52314003)(377424004)(189002)(199003)(24454002)(101416001)(93886005)(3280700002)(33646002)(2900100001)(6506006)(5660300001)(81156014)(81166006)(66066001)(99286003)(76176999)(6436002)(103116003)(3846002)(36756003)(102836003)(2950100002)(8676002)(50226002)(2906002)(97736004)(8936002)(6512007)(6116002)(39060400002)(6486002)(77096006)(478600001)(68736007)(50986999)(4326008)(2501003)(54906002)(229853002)(3660700001)(7736002)(25786009)(189998001)(6246003)(106356001)(305945005)(86362001)(105586002)(53936002)(14454004)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN4PR11MB0883;H:BN4PR11MB0996.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2017 14:00:53.6300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR11MB0883 X-OriginatorOrg: intel.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7UE141d012942 On Mon, 2017-08-28 at 16:20 +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 27, 2017 at 04:31:27PM +0300, Mika Westerberg wrote: > > > > On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote: > > > > > > On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote: > > > > > > > > The key size is tested by hex2bin() already (as '\0' isn't an > > > > hex digit) > > > > > > > > Suggested-by: Andy Shevchenko > > > > Signed-off-by: Yehezkel Bernat > > > Acked-by: Mika Westerberg > > Hi Greg, > > > > Do you have any comments regarding these patches? If not could you > > take > > them to your char-misc tree? > Will do, thanks. > > greg k-h Hi Greg, I'm not sure if you intended to do so anyway, but I think it worth adding to v4.13, as these are fixes (and somewhat security related). Thanks, Yehezkel