Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()'

Andy Shevchenko
2017-08-31T09:38:26Z

On Thu, 2017-08-31 at 11:35 +0200, Alexandre Belloni wrote:
> On 31/08/2017 at 12:04:03 +0300, Andy Shevchenko wrote:
> > On Thu, 2017-08-31 at 10:23 +0200, Julia Lawall wrote:
> > >
> > > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> > >
> > > > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > > > >

> > I didn't look into the code, though speculating it might be the case
> > when CLK framework is not enabled, though many drivers are dependent
> > to
> > it, so, it would never fail in such cases.
>
> It is not the case, it would return 0. Anyway, this will not happen
> because that driver depends on ARCH_AT91 which selects COMMON_CLK_AT91
> which selects COMMON_CLK.
>
> > Nevertheless there might be
> > other cases for CLK API to fail.
> >
>
> The only case would be for a clock to be enabled without being
> prepared
> and this will never happen because clk_prepare_enable is used.
>
> This call will just never fail.

So, then this is a bug of CLK API per se to have a prototype to return
int, right?

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy