From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752626AbdIBDwA (ORCPT ); Fri, 1 Sep 2017 23:52:00 -0400 Received: from smtprelay0173.hostedemail.com ([216.40.44.173]:36485 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750941AbdIBDv6 (ORCPT ); Fri, 1 Sep 2017 23:51:58 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:4321:5007:6119:7576:7903:10004:10400:10848:10967:11232:11658:11783:11889:11914:12043:12291:12485:12555:12679:12683:12690:12737:12740:12895:13069:13311:13357:13439:13894:14095:14181:14659:14721:14879:21080:21451:21627:30054:30055:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: note58_2e1221af63a4c X-Filterd-Recvd-Size: 1973 Message-ID: <1504324315.2361.25.camel@perches.com> Subject: Re: [PATCH] ipv6: sr: Use ARRAY_SIZE macro From: Joe Perches To: David Miller , thomas@m3y3r.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 01 Sep 2017 20:51:55 -0700 In-Reply-To: <20170901.183540.2023957151661748902.davem@davemloft.net> References: <20170831141815.28003-1-thomas@m3y3r.de> <20170901.183540.2023957151661748902.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-09-01 at 18:35 -0700, David Miller wrote: > From: Thomas Meyer > Date: Thu, 31 Aug 2017 16:18:15 +0200 > > > Grepping for "sizeof\(.+\) / sizeof\(" found this as one of the first > > candidates. > > Maybe a coccinelle can catch all of those. Umm: try scripts/coccinelle/misc/array_size.cocci Until then, maybe a perl script? $ git grep --name-only sizeof.*/.*sizeof drivers/net | \ xargs perl -p -i -e 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\/\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\)/ARRAY_SIZE(\1)/g' gives: $ git diff --stat drivers/net  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c                   |   2 +-  drivers/net/ethernet/mellanox/mlx4/fw.c                         |   4 +--  drivers/net/ethernet/mellanox/mlx4/main.c                       |   8 +++---  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c                  |   2 +-  drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c | 186 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------  5 files changed, 101 insertions(+), 101 deletions(-)