From: Byungchul Park <byungchul.park@lge.com>
To: tj@kernel.org, johannes.berg@intel.com, peterz@infradead.org,
mingo@kernel.org
Cc: tglx@linutronix.de, oleg@redhat.com, david@fromorbit.com,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: [PATCH 0/3] Fix the workqueue and lockdep annotation issue
Date: Tue, 5 Sep 2017 11:29:11 +0900 [thread overview]
Message-ID: <1504578554-4137-1-git-send-email-byungchul.park@lge.com> (raw)
We introduced the following commit to detect deadlocks caused by
wait_for_completion() in flush_{workqueue, work}() and other locks. But
now LOCKDEP_COMPLETIONS is introduced, such works are automatically done
by LOCKDEP_COMPLETIONS.
commit 4e6045f134784f4b158b3c0f7a282b04bd816887
workqueue: debug flushing deadlocks with lockdep
However, LOCKDEP_COMPLETIONS has limitation that it cannot report
deadlocks at the real time. So we have to leave some annotations for now,
but some redundant acquisitions can be removed. And we need to make
workqueue code co-work with LOCKDEP_COMPLETIONS.
Byungchul Park (3):
lockdep: Use enum type on hlock->read instead of magic number
lockdep: Introduce lock_acquire_might()
lockdep: Remove unnecessary acquisitions wrt workqueue flush
include/linux/lockdep.h | 2 ++
kernel/locking/lockdep.c | 56 ++++++++++++++++++++++++++++++++++--------------
kernel/workqueue.c | 18 +++++++---------
3 files changed, 50 insertions(+), 26 deletions(-)
--
1.9.1
next reply other threads:[~2017-09-05 2:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 2:29 Byungchul Park [this message]
2017-09-05 2:29 ` [PATCH 1/3] lockdep: Use enum type on hlock->read instead of magic number Byungchul Park
2017-09-05 2:29 ` [PATCH 2/3] lockdep: Introduce lock_acquire_might() Byungchul Park
2017-09-05 7:22 ` Peter Zijlstra
2017-09-12 0:35 ` Byungchul Park
2017-09-26 0:58 ` Byungchul Park
2017-09-05 2:29 ` [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park
2017-09-05 7:25 ` Peter Zijlstra
2017-09-05 7:36 ` 박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com)
2017-09-05 8:16 ` Peter Zijlstra
2017-09-05 8:19 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504578554-4137-1-git-send-email-byungchul.park@lge.com \
--to=byungchul.park@lge.com \
--cc=david@fromorbit.com \
--cc=johannes.berg@intel.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox