Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms

Greg KH
2017-09-05T14:14:32Z

On Tue, Sep 05, 2017 at 03:36:41PM +0530, Janani Sankara Babu wrote:
> This patch solves the following warning shown by checkpatch script
> Warning: msleep < 20ms can sleep for up to 20ms
>
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> index f86c9ce..78edc15 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> @@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
> DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
> break;
> }
> - msleep(1);
> + usleep_range(0, 1000);

How do you know this is a valid range to sleep for?