From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817AbdIGEvD (ORCPT ); Thu, 7 Sep 2017 00:51:03 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34219 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbdIGEvC (ORCPT ); Thu, 7 Sep 2017 00:51:02 -0400 X-Google-Smtp-Source: ADKCNb6sNYGfv+3U3JP9sU+lTRvlKv201icIJpi6HFkn1Ta8aS2tFoSkHVRLDvzc/3TjurfJWLtCEQ== From: Pushkar Jambhlekar To: Greg Kroah-Hartman , Georgiana Rodica Chelu , William Blough , Ivan Safonov , Yamanappagouda Patil , Pushkar Jambhlekar Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers/staging/rtl8188eu: cleanup crc32_init logic Date: Thu, 7 Sep 2017 10:20:52 +0530 Message-Id: <1504759852-2053-1-git-send-email-pushkar.iit@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org crc32_init is using unnecessary else condition. Cleaningup this function Signed-off-by: Pushkar Jambhlekar --- drivers/staging/rtl8188eu/core/rtw_security.c | 42 +++++++++++++-------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c index b283a490..9d17204 100644 --- a/drivers/staging/rtl8188eu/core/rtw_security.c +++ b/drivers/staging/rtl8188eu/core/rtw_security.c @@ -94,29 +94,29 @@ static u8 crc32_reverseBit(u8 data) static void crc32_init(void) { - if (bcrc32initialized == 1) { + if (bcrc32initialized == 1) return; - } else { - int i, j; - u32 c; - u8 *p = (u8 *)&c, *p1; - u8 k; - - c = 0x12340000; - - for (i = 0; i < 256; ++i) { - k = crc32_reverseBit((u8)i); - for (c = ((u32)k) << 24, j = 8; j > 0; --j) - c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1); - p1 = (u8 *)&crc32_table[i]; - - p1[0] = crc32_reverseBit(p[3]); - p1[1] = crc32_reverseBit(p[2]); - p1[2] = crc32_reverseBit(p[1]); - p1[3] = crc32_reverseBit(p[0]); - } - bcrc32initialized = 1; + + int i, j; + u32 c; + u8 *p = (u8 *)&c, *p1; + u8 k; + + c = 0x12340000; + + for (i = 0; i < 256; ++i) { + k = crc32_reverseBit((u8)i); + for (c = ((u32)k) << 24, j = 8; j > 0; --j) + c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1); + p1 = (u8 *)&crc32_table[i]; + + p1[0] = crc32_reverseBit(p[3]); + p1[1] = crc32_reverseBit(p[2]); + p1[2] = crc32_reverseBit(p[1]); + p1[3] = crc32_reverseBit(p[0]); } + + bcrc32initialized = 1; } static __le32 getcrc32(u8 *buf, int len) -- 2.7.4