From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753902AbdIGFzC (ORCPT ); Thu, 7 Sep 2017 01:55:02 -0400 Received: from smtprelay0114.hostedemail.com ([216.40.44.114]:52317 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752808AbdIGFzB (ORCPT ); Thu, 7 Sep 2017 01:55:01 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2894:3138:3139:3140:3141:3142:3622:3867:3871:3874:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12438:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: tank65_65b9c4d20f31c X-Filterd-Recvd-Size: 1441 Message-ID: <1504763697.7546.9.camel@perches.com> Subject: Re: [PATCH] security/keys: Adding newline after declaration From: Joe Perches To: Pushkar Jambhlekar , David Howells , James Morris , "Serge E. Hallyn" Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 06 Sep 2017 22:54:57 -0700 In-Reply-To: <1504762905-2424-1-git-send-email-pushkar.iit@gmail.com> References: <1504762905-2424-1-git-send-email-pushkar.iit@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-09-07 at 11:11 +0530, Pushkar Jambhlekar wrote: > Fixing checkpatch warning to add newline after declaration [] > diff --git a/security/keys/big_key.c b/security/keys/big_key.c [] > @@ -93,6 +93,7 @@ static int big_key_crypt(enum big_key_op op, u8 *data, size_t datalen, u8 *key) > { > int ret = -EINVAL; > struct scatterlist sgio; > + > SKCIPHER_REQUEST_ON_STACK(req, big_key_skcipher); checkpatch doesn't know that SKCIPHER_REQUEST_ON_STACK is actually 2 declarations.