From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Srishti Sharma <srishtishar@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
outreachy-kernel@googlegroups.com,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.
Date: Wed, 06 Sep 2017 23:16:52 -0700 [thread overview]
Message-ID: <1504765012.7546.12.camel@perches.com> (raw)
In-Reply-To: <20170906213243.gyttos3s64ckoswp@mwanda>
On Thu, 2017-09-07 at 00:32 +0300, Dan Carpenter wrote:
> Always compile your patches.
>
> CC [M] drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable ‘inflight_counter’ [-Wunused-variable]
> u32 inflight_counter;
> ^~~~~~~~~~~~~~~~
>
> You need to delete the declaration as well.
>
> Don't be in a rush to resend patches. I normally write them then let
> them sit in my outbox overnight and send them in the morning. The extra
> delay helps me to calm down a bit and focus better. Even though I've
> sent thousands of patches, it sometimes still stresses me out. It's
> like you're disagreeing with the original author and the reviewers are
> disagreeing with you and everyone's trying to be nice about it but
> patches are fundamentally points of disagreement and that's stress.
True, and you shouldn't add a blank link either.
there's already one above the block you deleted.
prev parent reply other threads:[~2017-09-07 6:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 21:13 [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable Srishti Sharma
2017-09-06 21:17 ` [Outreachy kernel] " Julia Lawall
2017-09-06 21:22 ` Srishti Sharma
2017-09-06 21:26 ` Julia Lawall
2017-09-06 21:27 ` Srishti Sharma
2017-09-06 21:32 ` Dan Carpenter
2017-09-06 21:42 ` Srishti Sharma
2017-09-07 6:16 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504765012.7546.12.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=srishtishar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox