From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754009AbdIGGqj (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Sep 2017 02:46:39 -0400
Received: from smtprelay0026.hostedemail.com ([216.40.44.26]:59828 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1753062AbdIGGqi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Sep 2017 02:46:38 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2899:2903:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3873:3874:4321:5007:9010:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13161:13229:13311:13357:13439:14659:14721:21080:21121:21433:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: iron58_7404d79313d32
X-Filterd-Recvd-Size: 1418
Message-ID: <1504766795.7546.16.camel@perches.com>
Subject: Re: [PATCH 1/1] x86:mm:return -ENOMEM if kzalloc() fails
From: Joe Perches <joe@perches.com>
To: Allen <allen.lkml@gmail.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Date: Wed, 06 Sep 2017 23:46:35 -0700
In-Reply-To: <CAOMdWSLJ8dNDnY0nUHre3W2FUNm4Jf+divKqmAgQR5tnBfQ6jA@mail.gmail.com>
References: <1504765607-23548-1-git-send-email-allen.lkml@gmail.com>
         <1504766031.7546.14.camel@perches.com>
         <CAOMdWSLJ8dNDnY0nUHre3W2FUNm4Jf+divKqmAgQR5tnBfQ6jA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-09-07 at 12:08 +0530, Allen wrote:
> > On Thu, 2017-09-07 at 11:56 +0530, Allen Pais wrote:
> > >  Currently on failure the value returned from kzalloc() is -1.
> > > It should return -ENOMEM.
> > > 
> > 
> > Looks like there are quite a few of these:
> > (probably several false positives too)
> 
>  The list is long. If the maintainers are okay with these clean-ups,
> i'll go ahead and get all of them done.

Make sure you check the calling chains to ensure that
the conversion from -1 to -12 doesn't break anything.