From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754556AbdIGKdb (ORCPT ); Thu, 7 Sep 2017 06:33:31 -0400 Received: from smtprelay0248.hostedemail.com ([216.40.44.248]:40728 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753905AbdIGKda (ORCPT ); Thu, 7 Sep 2017 06:33:30 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3873:4321:5007:10004:10400:10848:11026:11232:11658:11914:12043:12295:12296:12438:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: step64_3b5c9faca8230 X-Filterd-Recvd-Size: 1603 Message-ID: <1504780406.7546.19.camel@perches.com> Subject: Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings From: Joe Perches To: gaurav jindal , rjw@rjwysocki.net, daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, toddpoynor@google.com Date: Thu, 07 Sep 2017 03:33:26 -0700 In-Reply-To: <20170907102325.GA6427@kernel> References: <20170907102325.GA6427@kernel> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-09-07 at 15:53 +0530, gaurav jindal wrote: > This patch fixes the below checkpatch errors and warnings in > drivers/cpuidle/cpuidle.c If you are going to propose a checkpatch only patch, please run your proposed patch through checkpatch. > diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c [] > > @@ -399,9 +400,12 @@ int cpuidle_enable_device(struct cpuidle_device *dev) > if (ret) > return ret; > > - if (cpuidle_curr_governor->enable && > - (ret = cpuidle_curr_governor->enable(drv, dev))) > - goto fail_sysfs; > + if (cpuidle_curr_governor->enable) { > + > + ret = cpuidle_curr_governor->enable(drv, dev); > + if (ret) > + goto fail_sysfs; > + } checkpatch should complain here about unnecessary blank line after open brace