From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755361AbdIGPXG (ORCPT ); Thu, 7 Sep 2017 11:23:06 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35679 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753853AbdIGPXD (ORCPT ); Thu, 7 Sep 2017 11:23:03 -0400 X-ME-Sender: X-Sasl-enc: SKUs+QiTAB1KIBU2MbwFhdMIS6ll+waYqklyElWcBIQh 1504797782 Message-ID: <1504797770.5105.7.camel@aj.id.au> Subject: Re: [PATCH] hwmon: pmbus: Make reg check and clear faults functions return errors From: Andrew Jeffery To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, jdelvare@suse.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, joel@jms.id.au Date: Fri, 08 Sep 2017 01:22:50 +1000 In-Reply-To: References: <20170905070132.17682-1-andrew@aj.id.au> <20170905170002.GG11478@roeck-us.net> <1504657417.28363.8.camel@aj.id.au> <20170906225102.GA32210@roeck-us.net> <1504740749.5042.2.camel@aj.id.au> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Ora1ViZxeJ8Db5G7TexF" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-Ora1ViZxeJ8Db5G7TexF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-09-07 at 06:40 -0700, Guenter Roeck wrote: > On 09/06/2017 04:32 PM, Andrew Jeffery wrote: >=20 > > > =C2=A0=C2=A0 > > > Guess I need to dig up my eval board and see if I can reproduce the p= roblem. > > > Seems you are saying that the problem is always seen when issuing a s= equence > > > of "clear faults" commands on multiple pages ? > >=20 > > Yeah. We're also seeing bad behaviour under other command sequences as = well, > > which lead to this hack of a work-around patch[1]. > >=20 > > I'd be very interested in the results of testing against the eval board= . I > > don't have access to one and it seems Maxim have discontinued them. > >=20 >=20 > Do you have a somewhat reliable means to reproduce the problem ? It seems we hit a bunch of problems by just continually binding/unbinding the driver, if you don't apply that hacky oneshot retry patch. We can=C2=A0hit problems (in our design?) with something like: # cd /sys/bus/i2c/drivers/max31785; \ echo $addr > unbind; \ while echo $addr > bind; \ do echo $addr > unbind; echo -n .; done; It should hit issues covered by this patch, as the register checks are used in the operations used by probe. Andrew --=-Ora1ViZxeJ8Db5G7TexF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIcBAABCgAGBQJZsWRKAAoJEJ0dnzgO5LT5a6UP/Rvb2e4usgjlEBtXI4XJpTXd lLtEQ9xnaJa6o6+XAnfNIqmH9baCE5sA1jY7oWAlnqDe3+u3lpFVPlSQ9CLu8zol 78ca7RXOgt5XE36ImZVIx59/LAGhVu2+6GKrgzLo9/PSsNlutkAHb1kT00SjjBhU N00XKVHuJazGT/W1z/DRF+xOb0Cq9BnwebVwmoWuFvE6I4q/fb6O86TY4bu2CY2e OkPlLN3xZtazVTHXEdtgoeB1nvHClJgx3js9I3L8eSq72YW6dPzMM0RWdxlNq/Vo EIyEX0OzmNb+4J/yuSj81bAyLNwoQykP6TKoa0NoI9hoz+QPO+U6AMdLQsOyp2Ur 1zphLXIllHocHMTM6JO8jLHsBPSKLBRfJ7KlB3D5iawsOYaF9ovc1rgCtnCMuKPb hEzuZwmavf5HupWetDgR1mUPTipF0im2nfHvavDgrMdkUHLz8sEWhvRv7cYzaHIG h5UVZOulRxHpcxy6bMOA1OwzXBCAp7gq3+LJNRpII4NweD6l08Th6aEO96KC7SKs Z4SgKDB2KEbmJy4Tr0+IZa97GaKNtTXJsfVDRbbgmX8SN5xn3/YHLrkOQxCU5KuB 6tfSH+JinuUBY//TgZ3EmMWTC3S1d1fb8qWG8QgziMqqNA/7ibMgH5UO3uPqXzkN rZp+83EkW1uboBm4jt9E =9fWk -----END PGP SIGNATURE----- --=-Ora1ViZxeJ8Db5G7TexF--