From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"colin.king@canonical.com" <colin.king@canonical.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"jpinto@synopsys.com" <jpinto@synopsys.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"vinholikatti@gmail.com" <vinholikatti@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size
Date: Tue, 12 Sep 2017 15:10:54 +0000 [thread overview]
Message-ID: <1505229053.2537.0.camel@wdc.com> (raw)
In-Reply-To: <20170912113228.1389-1-colin.king@canonical.com>
On Tue, 2017-09-12 at 12:32 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrays on the stack, instead make them
> static. Makes the object code smaller by over 740 bytes.
>
> Before:
> text data bss dec hex filename
> 3840 208 0 4048 fd0 drivers/scsi/ufs/tc-dwc-g210.o
>
> After:
> text data bss dec hex filename
> 2679 624 0 3303 ce7 drivers/scsi/ufs/tc-dwc-g210.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Please CC the most active contributors of a driver when submitting a driver
patch. Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
next prev parent reply other threads:[~2017-09-12 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 11:32 [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size Colin King
2017-09-12 15:10 ` Bart Van Assche [this message]
2017-09-15 19:42 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505229053.2537.0.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jpinto@synopsys.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox