From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbdIMV6b (ORCPT ); Wed, 13 Sep 2017 17:58:31 -0400 Received: from smtprelay0191.hostedemail.com ([216.40.44.191]:45489 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751148AbdIMV63 (ORCPT ); Wed, 13 Sep 2017 17:58:29 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3867:3868:3870:3871:3872:4321:5007:6742:7903:8660:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13148:13230:13311:13357:13439:14181:14659:14721:21080:21434:21627:30012:30054:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: soup86_83a582d9e5c63 X-Filterd-Recvd-Size: 1931 Message-ID: <1505339903.8969.20.camel@perches.com> Subject: Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro From: Joe Perches To: Dan Carpenter , Greg KH Cc: Lars-Peter Clausen , devel@driverdev.osuosl.org, daniel.baluta@gmail.com, Himanshi Jain , Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, nick.desaulniers@gmail.com, outreachy-kernel@googlegroups.com, pmeerw@pmeerw.net, knaack.h@gmx.de, Jonathan Cameron Date: Wed, 13 Sep 2017 14:58:23 -0700 In-Reply-To: <20170913214333.mcw4f24fkzndwh5k@mwanda> References: <2bc7a124ab925dd2c50aa8c778745d179777d50d.1505291907.git.himshijain.hj@gmail.com> <20170913180310.27cbf1b1@archlinux> <20170913185805.GB26390@kroah.com> <5e43ea4d-eab8-c4be-c5dc-2f862578d011@metafoo.de> <20170913212952.GD9288@kroah.com> <20170913214333.mcw4f24fkzndwh5k@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote: > He was exagerating a bit to call it a "static checker" warning... Not really. False positives and false negatives exist in just about every static checker. > It's just checkpatch.pl complaining about adding spaces around the - > operator. checkpatch is a brain-damaged by design static checker. regexes can only be sensitive to patterns, not compiled code. > The sysfs file has a hyphen in the middle. Another option would be to use an underscore instead.