From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"shuwang@redhat.com" <shuwang@redhat.com>,
"kashyap.desai@broadcom.com" <kashyap.desai@broadcom.com>,
"shivasharan.srikanteshwara@broadcom.com"
<shivasharan.srikanteshwara@broadcom.com>,
"sumit.saxena@broadcom.com" <sumit.saxena@broadcom.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chuhu@redhat.com" <chuhu@redhat.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"yizhan@redhat.com" <yizhan@redhat.com>,
"megaraidlinux.pdl@broadcom.com" <megaraidlinux.pdl@broadcom.com>
Subject: Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion
Date: Fri, 15 Sep 2017 16:16:57 +0000 [thread overview]
Message-ID: <1505492215.3420.1.camel@wdc.com> (raw)
In-Reply-To: <20170915052152.5032-1-shuwang@redhat.com>
On Fri, 2017-09-15 at 13:21 +0800, shuwang@redhat.com wrote:
> @@ -4548,9 +4556,11 @@ megasas_free_fusion_context(struct megasas_instance *instance)
>
> if (is_vmalloc_addr(fusion))
> vfree(fusion);
> - else
> + else {
> + kmemleak_free(fusion);
> free_pages((ulong)fusion,
> instance->ctrl_context_pages);
> + }
> }
Braces are still not balanced in the above code. This is something
checkpatch should have told you. Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
next prev parent reply other threads:[~2017-09-15 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 5:21 [PATCH V2] megaraid: kmemleak: Track page allocation for fusion shuwang
2017-09-15 13:12 ` Catalin Marinas
2017-09-15 16:16 ` Bart Van Assche [this message]
2017-09-15 18:00 ` Christoph Hellwig
2017-09-18 15:10 ` Shivasharan Srikanteshwara
2017-09-18 16:21 ` Christoph Hellwig
2017-09-25 8:08 ` Shivasharan Srikanteshwara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505492215.3420.1.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=catalin.marinas@arm.com \
--cc=chuhu@redhat.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=shuwang@redhat.com \
--cc=sumit.saxena@broadcom.com \
--cc=yizhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox