From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751970AbdIQUos (ORCPT ); Sun, 17 Sep 2017 16:44:48 -0400 Received: from smtprelay0009.hostedemail.com ([216.40.44.9]:48023 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751646AbdIQUor (ORCPT ); Sun, 17 Sep 2017 16:44:47 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3350:3622:3867:3872:4321:4605:5007:10004:10400:10848:11232:11658:11914:12043:12555:12740:12760:12895:12986:13069:13311:13357:13439:13618:14181:14659:21080:21451:21627:30054:30070:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: debt32_c11e33f84327 X-Filterd-Recvd-Size: 1544 Message-ID: <1505681081.16316.13.camel@perches.com> Subject: Re: [PATCH] checkpatch: do not check missing blank line before builtin_*_driver From: Joe Perches To: Masahiro Yamada , Andy Whitcroft Cc: Paul Gortmaker , linux-kernel@vger.kernel.org Date: Sun, 17 Sep 2017 13:44:41 -0700 In-Reply-To: <1505660376-10646-1-git-send-email-yamada.masahiro@socionext.com> References: <1505660376-10646-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-09-17 at 23:59 +0900, Masahiro Yamada wrote: > checkpatch.pl does not check missing blank line before module_*_driver. > I want it to behave likewise for builtin_*_driver. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index dd2c262aebbf..cec896306619 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3103,6 +3103,7 @@ sub process { > $line =~ /^\+[a-z_]*init/ || > $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || > $line =~ /^\+\s*DECLARE/ || > + $line =~ /^\+\s*builtin_/ || I believe $line =~ /^\+\s*builtin_[\w_]*driver/ || would be better