From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.g.garry@oracle.com>,
Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-mm@kvack.org, Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Shakeel Butt <shakeel.butt@linux.dev>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Michal Hocko <mhocko@kernel.org>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [REGRESSION][BISECTED] Unexpected OOM instead of reclaiming inactive file pages
Date: Mon, 11 Aug 2025 22:42:46 +0200 [thread overview]
Message-ID: <15056829.uLZWGnKmhe@natalenko.name> (raw)
In-Reply-To: <199fb020-19ee-89d1-6373-7cc7f5babab8@google.com>
[-- Attachment #1: Type: text/plain, Size: 3175 bytes --]
Hello.
On pondělí 11. srpna 2025 18:06:16, středoevropský letní čas David Rientjes wrote:
> On Mon, 11 Aug 2025, Oleksandr Natalenko wrote:
>
> > Hello Damien.
> >
> > I'm fairly confident that the following commit
> >
> > 459779d04ae8d block: Improve read ahead size for rotational devices
> >
> > caused a regression in my test bench.
> >
> > I'm running v6.17-rc1 in a small QEMU VM with virtio-scsi disk. It has got 1 GiB of RAM, so I can saturate it easily causing reclaiming mechanism to kick in.
> >
> > If MGLRU is enabled:
> >
> > $ echo 1000 | sudo tee /sys/kernel/mm/lru_gen/min_ttl_ms
> >
> > then, once page cache builds up, an OOM happens without reclaiming inactive file pages: [1]. Note that inactive_file:506952kB, I'd expect these to be reclaimed instead, like how it happens with v6.16.
> >
> > If MGLRU is disabled:
> >
> > $ echo 0 | sudo tee /sys/kernel/mm/lru_gen/min_ttl_ms
> >
> > then OOM doesn't occur, and things seem to work as usual.
> >
> > If MGLRU is enabled, and 459779d04ae8d is reverted on top of v6.17-rc1, the OOM doesn't happen either.
> >
> > Could you please check this?
> >
>
> This looks to be an MGLRU policy decision rather than a readahead
> regression, correct?
>
> Mem-Info:
> active_anon:388 inactive_anon:5382 isolated_anon:0
> active_file:9638 inactive_file:126738 isolated_file:0
>
> Setting min_ttl_ms to 1000 is preserving the working set and triggering
> the oom kill is the only alternative to free memory in that configuration.
> The oom kill is being triggered by kswapd for this purpose.
>
> So additional readahead would certainly increase that working set. This
> looks working as intended.
OK, this makes sense indeed, thanks for the explanation. But is inactive_file explosion expected and justified?
Without revert:
$ echo 3 | sudo tee /proc/sys/vm/drop_caches; free -m; sudo journalctl -kb >/dev/null; free -m
3
total used free shared buff/cache available
Mem: 690 179 536 3 57 510
Swap: 1379 12 1367
/* OOM happens here */
total used free shared buff/cache available
Mem: 690 177 52 3 561 513
Swap: 1379 17 1362
With revert:
$ echo 3 | sudo tee /proc/sys/vm/drop_caches; free -m; sudo journalctl -kb >/dev/null; free -m
3
total used free shared buff/cache available
Mem: 690 214 498 4 64 476
Swap: 1379 0 1379
/* no OOM */
total used free shared buff/cache available
Mem: 690 209 462 4 119 481
Swap: 1379 0 1379
The journal folder size is:
$ sudo du -hs /var/log/journal
575M /var/log/journal
It looks like this readahead change causes far more data to be read than actually needed?
--
Oleksandr Natalenko, MSE
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-08-11 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 15:48 [REGRESSION][BISECTED] Unexpected OOM instead of reclaiming inactive file pages Oleksandr Natalenko
2025-08-11 16:06 ` David Rientjes
2025-08-11 20:42 ` Oleksandr Natalenko [this message]
2025-08-12 0:45 ` Damien Le Moal
2025-08-12 7:37 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15056829.uLZWGnKmhe@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@redhat.com \
--cc=dlemoal@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=martin.petersen@oracle.com \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=shakeel.butt@linux.dev \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).