From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbdISKxW (ORCPT ); Tue, 19 Sep 2017 06:53:22 -0400 Received: from mail-sn1nam01on0063.outbound.protection.outlook.com ([104.47.32.63]:37275 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751205AbdISKxT (ORCPT ); Tue, 19 Sep 2017 06:53:19 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1505818394.29684.13.camel@nxp.com> Subject: Re: [PATCH] thermal: imx: add NVMEM dependency From: Leonard Crestez To: Arnd Bergmann , Zhang Rui , "Eduardo Valentin" CC: Shawn Guo , , Date: Tue, 19 Sep 2017 13:53:14 +0300 In-Reply-To: <20170918204825.159177-1-arnd@arndb.de> References: <20170918204825.159177-1-arnd@arndb.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131502919980008341;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(376002)(346002)(39380400002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(377424004)(24454002)(97736004)(104016004)(36756003)(53936002)(4326008)(68736007)(5660300001)(81166006)(50226002)(305945005)(81156014)(8936002)(8676002)(103116003)(356003)(86362001)(47776003)(77096006)(54906002)(498600001)(2950100002)(6246003)(39060400002)(110136005)(85426001)(2906002)(105606002)(106466001)(5820100001)(229853002)(316002)(33646002)(2870700001)(23676002)(50986999)(76176999)(50466002)(189998001)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR03MB2704;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD013;1:7v/GGvWkgZwxuV3eohn6j0A1hLWQP2jwrdKd+qhal3vxghkHnvp8Fs8oWAk/gt7ze5alBarivgrmCzdxvg+3ko3cBcKgn8e89JavoxxBTHckUeq9JRGhE3nhYqeWycBj X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0a176d42-e07b-4521-c395-08d4ff4ca2cc X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR03MB2704; X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2704;3:z0kZQcoAyDawbpdvxot2lbG3rbpuXGHtp8fi1OcLaqU2h8biJtS5FQxS2NP4WiTKECBTJCc216DcgQyzTh9g8QWrQ7f5xOkUNdzm4Ai/l9KeYKXO45OJbyr25JQwdQDaeCBzDp21cZJ/Itvh5Eiyhy8HavEhD9BVPaepK3EuvffUV/+ZfwZoWH2XPhnwYKC1j4JFETF6OPm+U0nH1OZJp+ihbaYAa8OrWfSnMg2/wBYsQj0vBDpDp6KnSfZ1KXFsgbMBrO9/PQgQ5rJ9g8mLfkeoDUzxDjEjWa/ulfVlRlN+qE6FsvgJYsJod0K6OkC5XY05FPmfhFotIE2k/3Ix77xiOCh8WOeEl7gWqKvt8o0=;25:1eFteJhEGQXsBrB88KAk/ADJopG8K45Zx6mI03DB/ja26CeVILLm0coBMHRpFZfzqo1/x63ZZ0hcLAckv0oXFINFo8iRTMlO/+OuInaaVIF8cMn95HEGmuAnjCerAzRUHHvXCpegD8k4+USGqbNGZ6fDfGDBLX0KgFissySN4ilaB1IGRF6s2RCuGiW1wGude1wjAoQzYIW07cWlatG0lDGy+ycqoD1hTQFgNXQ48u6F0rwAQfiBknyDdgTVw/DHfDWxmywOARKsJDDf8rTWafPjR719R86SVBCyP1b1e6y+Q8annqkK5MRfnUafk/GmoJlSVi5INqLX7y1hFMx7+Q== X-MS-TrafficTypeDiagnostic: MWHPR03MB2704: X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2704;31:psvLBTETkfnm0pzehfYwHSP9b5ELzQ656LOy7cucnbe+lmeegrFfmwI6oeiM74PV8Kn3Pmqfp4O42oJU1gckkr/2mVzRsYSbXWho8JSKUX7kwlNHYM0IGGH46xkP76P+iFPua/JJ8L35v3CSyBwzOuq+j2rchCVHftAc0uCx6KI7vLOlXcZJTcg0sbCzSnholeodLQYzfz0ahf0BPt4TVMySKfEyZTLVPR66atiW8mU=;4:ANiUPCxrRwTDCbo4wFdIaByJ51W3NAxHIoig3z8KT0O03udo00VflysqvumInXKb3o1YQmXb58cGXmKdPLQ69oe8qiMM/LKtvhZCcz1mB/GKl+WB7KvqIaJTXNdhy2H2mlFQ7G9LscrU0wED0NMZ2Q79YyD8CwGM4J2Z4dXHzv0xIFj6MoN+sbaTPn+3dmJyaN8Z2zvSplWCsLwWkYT0S+yKkLpi94/W79vtBPZ+XfRO1vPnSaQCrm089wPrXUFsCG+G2i54DHJFzQpP+Wca4GYK96JxsTjxMEy2COhLjfo= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123559100)(20161123556025)(20161123565025)(20161123561025)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR03MB2704;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR03MB2704; X-Forefront-PRVS: 04359FAD81 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjAzTUIyNzA0OzIzOnNheWRydUxTT3BNRzI3blBsL1dqVy9GK2hD?= =?utf-8?B?dmh3aW1XNVRva1NHWlIvM0tQS1hvSGFOV3J1V3JPUkZNdE4vMUFyMlBWWTZ5?= =?utf-8?B?YmVFMlJaenlvaFo0Mmc2VXJRdW9SUkNoTDQrK29ZNVQ3RzcyNld6a1JsY1Rx?= =?utf-8?B?bnNMVmpPcVlQcnhhQVVnQ0dGaERtTDhOekdEZ3kwZG1uYkROWURrRjZ6QVN2?= =?utf-8?B?Y1ZNUjRTMm9taHNCekhRbS8rMnJBVG10ZG90Tk83SnVabnFONTVScXIzazZ0?= =?utf-8?B?VkpXZUFIRWI5cGZpSWYzYjE2MDdtbHpKWnUzMHp6Vmprdi9KaTc0TXRVaWZK?= =?utf-8?B?KzhqdFIxNzFya2lBWjYrTXRyV3BTUkIrSWEvb1RITDk0WUlRbVJ5V2pHWFJV?= =?utf-8?B?M0NMeHJJemwxV1RQUWs2Z3RjVTFKU1FwaVJIaUJtbGJCaWJtVjdnbW9vK091?= =?utf-8?B?RkRHZ003Z3MycDArWWpKdGEzK0locVpuNitCZ3FhUkhWb3pwc3BCN1FISTgy?= =?utf-8?B?Wlh1bGNhVEpCZ1VJOGJlL1NvUHpxdmUzN1c3ZDg1VFNHc1NyTzdVb2U4d0Qz?= =?utf-8?B?L3ZjRzIrMHA5YnQrWkFJZVYvVE56aXhCYTVPUnJnYVpraU53NGRaalVjOGZa?= =?utf-8?B?OXpOMk9GYzRKT3R0cDR5T1YrK0hTQ2prb2hTZ1IzTTdOZkZpQTFzdlJSVitQ?= =?utf-8?B?cC96MnE4RnZRZXpzNmJXZ3VTR21jN1gwOEh5K1FjRXV6M29lZ0RmanZTNW9S?= =?utf-8?B?T0JsL05sWTNiZUlUeGIrSlkzcEV6Zm1oTzdrSlNvdVFyUUZKUWZzUlBSUkxl?= =?utf-8?B?M0NLWlhhVlBaSm5sUWw3aER2cVdMckdqSW5xZ1FoK0s1NlFyTnNkeTZHRS90?= =?utf-8?B?U1NacmVDMmgyL3ZSdU4reExPNnF0U2tucURpbDhTYTZjcS9MbVNEbmJFZ0Fm?= =?utf-8?B?K3B1MS9YSjA4WU9kNG5MbzNuSTJGWmlZNG45RHh6T2xqd2t0bmVyV2h4T3Y4?= =?utf-8?B?TzVVTXo1dHorNXFZLzJ5RTJZcVhXRTRPd0xwbGovRW5CWUt0QkNNZlBvZjhI?= =?utf-8?B?dGxhZjEydnpaanZ6ek1nVkM5dUd4b3Y2SFQ3RzduaWZYaWFCT0ZNRytScEhP?= =?utf-8?B?Zi9NWW9rZjBpaTB5RW5KdVVraXBMRFc1eXhtTStQUWdZMWZud2ZvNHBOV3Aw?= =?utf-8?B?VWJQWWFuYyt2WS9qNGNQaTdSYmo2WXEyNFB2ckZuUlZNMXlteldTRng0YmZH?= =?utf-8?B?ZnZVb2VWUkFGSmJFbzRCMlVoR3VUN3NqR2lXejBjdWptdytLZWdZR3FseXVB?= =?utf-8?B?UUlhaW8rLzMrOHpoelFYN3Nvb28zRWU5SnJKUXRPYUdmTDZtVzBVZHRUK2VD?= =?utf-8?B?NTFsNm9SZGk3VGMvTEd4QUtsTEVucGV3d0hXK0ttbjB0NTcybEgvNTlxZUxl?= =?utf-8?B?RXo2NElEMTNMRXhUajZzQ0VaWmVhUyt3NEtGR01tQzd1YU00Ni9ycDU2OUdr?= =?utf-8?B?bzRFbkN5bkV5bmVIUllDS1BKeXNZVjNkcHZETm9PTHZRRndrYStSVXhFTU1p?= =?utf-8?B?ZEpISlhDMFdEdWp4NzN5R3NiMmRlckZ1NUVXbVMzbVdHZzlPOVpPS0t2SVJN?= =?utf-8?B?Uy8wQUVtdFlPeVhBbUtEaWVORElYNVhmK0VtM1FpRDJhOVkxZDUwVEdLQVYr?= =?utf-8?Q?f2ek2J5WrsQ52ftNjlAaZGd3CAON2lZXCjBeU6l?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2704;6:P6YdUdrY7X2SfcfINkFx7lm5ayyOJSuUIb0iFzPfCQNAQbUyypaQR9f7bp0pm0r7kXlbN26OvB8RA22rr5K+1s5NPDltpaUO0D/5tNFhOwxKpFPopsfW/p9XY6+9aGGxGQmUEWhTgM6dAYPocbfHC+1XfBGetijijalfyb/wmtyNuSeDeq5V+l+lo6tn39mn8zedh4F/Xac06uCOkUqb07CggQBdl9M8vDJvJbmUkkOzoc4xxUuzw7txOzVpO4/2jyJ3zTJwxuOsBnQgbhlFC0DOiQ/RW6nwZyKW6gLZZ3pWdVvhDGlc0RkSuHd5CdOqer5wlV11jXJ4bKc7264ruA==;5:P89+jZPBEQsVRHB929blY94DH/v8hLn1q/6tr+rZQF6tw7L2Olecdv9Xeo4zrB+aE4mIvEYqiCm9Dpf1XKkGsDSGys68xaqaToyJt8UpOdxyPVXAdKtYSK8lpnVucDNV4D7IPq8S/o9P+tEhDEA1wQ==;24:nDWBI7OKcT9Ela2jiOUC1tnxDSTp5NaOdui1RWOXbyWDrFh7rTTzJVy1xCvzNx5D+YnPdD3ZLXmCihKCmlBcVij2HZQbn0e4eGzjVKNjgTI=;7:7bhq77mIv9nVtbjJ+fPXzUFHTtTN5+sMR0B2o6ba1qDHuYXQI11tuCpzYwFTmFhMkgr7H2rBpTgU5W3QqcSyxqOW2oFGuUj1kpbZkY0Fx+mw1WKwiTL6uQWfaAH+hs9Y1M+EqqY3gALjV6PFUzo/rf1geWkL/sTOvaMshmJ6r9hGnQYiAsfIjyHtjIrBgEhlzEUDtPBZc7dfvd7INywHhOecwZWt98xuO5KtdqJY+58= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 10:53:17.8448 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2704 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-09-18 at 22:48 +0200, Arnd Bergmann wrote: > The driver now fails to link into vmlinux when CONFIG_NVMEM is a loadable > module: > > drivers/thermal/imx_thermal.o: In function `imx_thermal_probe': > imx_thermal.c:(.text+0x360): undefined reference to > `nvmem_cell_read_u32' > imx_thermal.c:(.text+0x360): relocation truncated to fit: > R_AARCH64_CALL26 against undefined symbol `nvmem_cell_read_u32' > imx_thermal.c:(.text+0x388): undefined reference to > `nvmem_cell_read_u32' > imx_thermal.c:(.text+0x388): relocation truncated to fit: > R_AARCH64_CALL26 against undefined symbol `nvmem_cell_read_u32' > > This adds a Kconfig dependency to force it to be a module as well > when its dependency is loadable. This must be a very strange config with NVMEM=m and IMX_THERMAL=y on arm64. Still, it makes sense that it should work at least at the Kconfig level. > Fixes: 7fe5ba04fcdc ("thermal: imx: Add support for reading OCOTP through nvmem") > Signed-off-by: Arnd Bergmann Reviewed-by: Leonard Crestez > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 07002df4f83a..cb14f1ec5953 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -206,6 +206,7 @@ config HISI_THERMAL >  config IMX_THERMAL >   tristate "Temperature sensor driver for Freescale i.MX SoCs" >   depends on (ARCH_MXC && CPU_THERMAL) || COMPILE_TEST > + depends on NVMEM || !NVMEM The || !NVMEM part is so that it also works when NVMEM=n, right?