From: Miklos Szeredi <mszeredi@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Steve French <sfrench@samba.org>
Subject: [PATCH 02/10] cifs: honor AT_STATX_DONT_SYNC
Date: Wed, 20 Sep 2017 10:39:57 +0200 [thread overview]
Message-ID: <1505896805-12055-3-git-send-email-mszeredi@redhat.com> (raw)
In-Reply-To: <1505896805-12055-1-git-send-email-mszeredi@redhat.com>
The description of this flag says "Don't sync attributes with the server".
In other words: always use the attributes cached in the kernel and don't
send network or local messages to refresh the attributes.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Cc: Steve French <sfrench@samba.org>
---
fs/cifs/inode.c | 30 ++++++++++++++++--------------
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index a8693632235f..982ba2e4f549 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -2003,22 +2003,24 @@ int cifs_getattr(const struct path *path, struct kstat *stat,
struct inode *inode = d_inode(dentry);
int rc;
- /*
- * We need to be sure that all dirty pages are written and the server
- * has actual ctime, mtime and file length.
- */
- if (!CIFS_CACHE_READ(CIFS_I(inode)) && inode->i_mapping &&
- inode->i_mapping->nrpages != 0) {
- rc = filemap_fdatawait(inode->i_mapping);
- if (rc) {
- mapping_set_error(inode->i_mapping, rc);
- return rc;
+ if (!(flags & AT_STATX_DONT_SYNC)) {
+ /*
+ * We need to be sure that all dirty pages are written and the
+ * server has actual ctime, mtime and file length.
+ */
+ if (!CIFS_CACHE_READ(CIFS_I(inode)) && inode->i_mapping &&
+ inode->i_mapping->nrpages != 0) {
+ rc = filemap_fdatawait(inode->i_mapping);
+ if (rc) {
+ mapping_set_error(inode->i_mapping, rc);
+ return rc;
+ }
}
- }
- rc = cifs_revalidate_dentry_attr(dentry);
- if (rc)
- return rc;
+ rc = cifs_revalidate_dentry_attr(dentry);
+ if (rc)
+ return rc;
+ }
generic_fillattr(inode, stat);
stat->blksize = CIFS_MAX_MSGSIZE;
--
2.5.5
next prev parent reply other threads:[~2017-09-20 8:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:39 [PATCH 00/10] honor AT_STATX_DONT_SYNC in netfs Miklos Szeredi
2017-09-20 8:39 ` [PATCH 01/10] ceph: honor AT_STATX_DONT_SYNC Miklos Szeredi
2017-09-20 8:39 ` Miklos Szeredi [this message]
2017-09-21 18:14 ` [PATCH 02/10] cifs: " Steve French
2017-09-20 8:39 ` [PATCH 03/10] coda: " Miklos Szeredi
2017-09-20 20:04 ` Jan Harkes
2017-09-21 12:45 ` Miklos Szeredi
2017-09-20 8:39 ` [PATCH 04/10] fuse: " Miklos Szeredi
2017-09-20 8:40 ` [PATCH 05/10] gfs2: " Miklos Szeredi
2017-09-20 8:40 ` [PATCH 06/10] lustre: " Miklos Szeredi
2017-09-20 8:40 ` [PATCH 07/10] nfs: " Miklos Szeredi
2017-09-20 8:40 ` [PATCH 08/10] ocfs2: " Miklos Szeredi
2017-09-20 8:40 ` [PATCH 09/10] orangefs: " Miklos Szeredi
2017-09-20 8:40 ` [PATCH 10/10] 9p: " Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505896805-12055-3-git-send-email-mszeredi@redhat.com \
--to=mszeredi@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).