From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842AbdIUUR6 (ORCPT ); Thu, 21 Sep 2017 16:17:58 -0400 Received: from smtprelay0227.hostedemail.com ([216.40.44.227]:41763 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751728AbdIUUR4 (ORCPT ); Thu, 21 Sep 2017 16:17:56 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2828:2914:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3871:3872:3873:4184:4321:4605:5007:6119:7875:7903:9010:10004:10400:10848:11026:11232:11657:11658:11914:12043:12050:12555:12740:12760:12895:13069:13095:13161:13229:13311:13357:13439:14180:14181:14659:14721:21060:21080:21433:21451:21611:21627:30054:30062:30064:30070:30080:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: wall52_abad6d9ebd43 X-Filterd-Recvd-Size: 2984 Message-ID: <1506025072.12311.29.camel@perches.com> Subject: Re: [PATCH V5 1/4] soc: brcmstb: Add Product ID and Family ID helper functions From: Joe Perches To: Al Cooper , Kishon Vijay Abraham I Cc: Florian Fainelli , Al Cooper , linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , BCM Kernel Feedback , Greg Kroah-Hartman , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel@lists.infradead.org Date: Thu, 21 Sep 2017 13:17:52 -0700 In-Reply-To: References: <1503683495-11766-1-git-send-email-alcooperx@gmail.com> <1503683495-11766-2-git-send-email-alcooperx@gmail.com> <3aefb1ca-827d-6ebf-03c6-1f0d41e5da5c@gmail.com> <0deddef3-fc3e-67be-12e8-9fbd84f24314@ti.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-09-21 at 15:16 -0400, Al Cooper wrote: > Kishon, > > I ran checkpatch on all my patches before submitting them and didn't > get any warnings. It looks like you may be running checkpatch with the > "--subjective" option. Is this a requirement and if so are there any > other checkpatch options I should be using? > > Thanks > Al > > On Thu, Sep 21, 2017 at 4:54 AM, 'Kishon Vijay Abraham I' via > BCM-KERNEL-FEEDBACK-LIST,PDL > wrote: > > Hi, > > > > On Saturday 02 September 2017 07:45 AM, Florian Fainelli wrote: > > > On 08/25/2017 10:51 AM, Al Cooper wrote: [] > > I get the following checkpatch warning > > CHECK: Macro argument reuse 'reg' - possible side-effects? > > #110: FILE: include/linux/soc/brcmstb/brcmstb.h:4: > > +#define BRCM_ID(reg) ((u32)reg >> 28 ? (u32)reg >> 16 : (u32)reg >> 8) [] > > > > diff --git a/include/linux/soc/brcmstb/brcmstb.h b/include/linux/soc/brcmstb/brcmstb.h > > > > index 337ce41..23e4dc9 100644 > > > > --- a/include/linux/soc/brcmstb/brcmstb.h > > > > +++ b/include/linux/soc/brcmstb/brcmstb.h > > > > @@ -1,10 +1,20 @@ > > > > #ifndef __BRCMSTB_SOC_H > > > > #define __BRCMSTB_SOC_H > > > > > > > > +#define BRCM_ID(reg) ((u32)reg >> 28 ? (u32)reg >> 16 : (u32)reg >> 8) > > > > +#define BRCM_REV(reg) ((u32)reg & 0xff) These should be (reg) to avoid a possible issue with cast precedence or maybe a use a statement expression macro with a temporary to avoid the reuse message.