public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Williams, Dan J" <dan.j.williams@intel.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: [GIT PULL] libnvdimm fixes for 4.14-rc2
Date: Thu, 21 Sep 2017 21:07:45 +0000	[thread overview]
Message-ID: <1506028051.30769.1.camel@intel.com> (raw)

Hi Linus, please pull from:

  git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes

...to receive a crash fix and corresponding regression test enabling
for the crash scenario. The unit test for this crash is available in
ndctl-v58.2. This branch has received a build success notification from
the 0day-kbuild robot over 148 configs. The fix is tagged for -stable /
backport to 4.13.

---

The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e:

  Linux 4.14-rc1 (2017-09-16 15:47:51 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes

for you to fetch changes up to 33a56086712561b8b9cdc881e0317f4c36861f72:

  libnvdimm, namespace: fix btt claim class crash (2017-09-18 17:29:01 -0700)

----------------------------------------------------------------
Dan Williams (2):
      tools/testing/nvdimm: disable labels for nfit_test.1
      libnvdimm, namespace: fix btt claim class crash

 drivers/nvdimm/namespace_devs.c  | 9 +++++++++
 tools/testing/nvdimm/test/nfit.c | 3 ---
 2 files changed, 9 insertions(+), 3 deletions(-)

commit 5e75fe3927559505682b0053b5745e3f42d66e8c
Author: Dan Williams <dan.j.williams@intel.com>
Date:   Mon Sep 18 17:19:10 2017 -0700

    tools/testing/nvdimm: disable labels for nfit_test.1
    
    Improve coverage of NVDIMM-N test scenarios by providing a test bus
    incapable of label operations.
    
    Signed-off-by: Dan Williams <dan.j.williams@intel.com>

commit 33a56086712561b8b9cdc881e0317f4c36861f72
Author: Dan Williams <dan.j.williams@intel.com>
Date:   Mon Sep 18 14:48:58 2017 -0700

    libnvdimm, namespace: fix btt claim class crash
    
    Maurice reports:
    
        BUG: unable to handle kernel NULL pointer dereference at 0000000000000028
        IP: holder_class_store+0x253/0x2b0 [libnvdimm]
    
    ...while trying to reconfigure an NVDIMM-N namespace into 'sector' /
    'btt' mode. The crash points to this line:
    
        (gdb) li *(holder_class_store+0x253)
        0x7773 is in holder_class_store (drivers/nvdimm/namespace_devs.c:1420).
        1415            for (i = 0; i < nd_region->ndr_mappings; i++) {
        1416                    struct nd_mapping *nd_mapping = &nd_region->mapping[i];
        1417                    struct nvdimm_drvdata *ndd = to_ndd(nd_mapping);
        1418                    struct nd_namespace_index *nsindex;
        1419
        1420                    nsindex = to_namespace_index(ndd, ndd->ns_current);
    
    ...where we are failing because ndd is NULL due to NVDIMM-N dimms not
    supporting labels.
    
    Long story short, default to the BTTv1 format in the label-less /
    NVDIMM-N case.
    
    Fixes: 14e494542636 ("libnvdimm, btt: BTT updates for UEFI 2.7 format")
    Cc: <stable@vger.kernel.org>
    Cc: Vishal Verma <vishal.l.verma@intel.com>
    Reported-by: Maurice A. Saldivar <maurice.a.saldivar@hpe.com>
    Tested-by: Maurice A. Saldivar <maurice.a.saldivar@hpe.com>
    Signed-off-by: Dan Williams <dan.j.williams@intel.com>

                 reply	other threads:[~2017-09-21 21:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506028051.30769.1.camel@intel.com \
    --to=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox