From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752426AbdIVRQf (ORCPT ); Fri, 22 Sep 2017 13:16:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35354 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751875AbdIVRQd (ORCPT ); Fri, 22 Sep 2017 13:16:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1AFEEC057FA8 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com Message-ID: <1506100590.5172.6.camel@redhat.com> Subject: Re: [PATCH] IB/core: fix incorrect fall-through on switch statement From: Doug Ledford To: Leon Romanovsky , Colin King Cc: Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 22 Sep 2017 13:16:30 -0400 In-Reply-To: <20170913164917.GU3405@mtr-leonro.local> References: <20170911160313.28240-1-colin.king@canonical.com> <20170913164917.GU3405@mtr-leonro.local> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 22 Sep 2017 17:16:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-09-13 at 19:49 +0300, Leon Romanovsky wrote: > On Mon, Sep 11, 2017 at 05:03:13PM +0100, Colin King wrote: > > From: Colin Ian King > > > > In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and > > add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN > > however the case OCRDMA_MBX_STATUS_FAILED is missing a break and > > falls through to the default case which then re-assigns err_num > > to -EFAULT. Fix this so that err_num is assigned to -EAGAIN > > for the add_status OCRDMA_MBX_STATUS_FAILED case and -EFAULT > > otherwise. > > > > Detected by CoverityScan CID#703125 ("Missing break in switch") > > > > Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect > > IBoE RDMA adapter") > > Signed-off-by: Colin Ian King > > --- > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > Except the wrong title: IB/core -> IB/ocrdma > > Reviewed-by: Leon Romanovsky Thanks, patch (with fixed subject) applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD