From: Rik van Riel <riel@surriel.com>
To: Gargi Sharma <gs051095@gmail.com>, linux-kernel@vger.kernel.org
Cc: julia.lawall@lip6.fr, akpm@linux-foundation.org,
mingo@kernel.org, pasha.tatashin@oracle.com,
ktkhai@virtuozzo.com, oleg@redhat.com
Subject: Re: [PATCH 4/4] pid: Remove pidhash
Date: Mon, 25 Sep 2017 09:48:29 -0400 [thread overview]
Message-ID: <1506347309.21121.84.camel@surriel.com> (raw)
In-Reply-To: <e356d619a1c93b873966427821447a859606e605.1506342921.git.gs051095@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 954 bytes --]
On Mon, 2017-09-25 at 08:56 -0400, Gargi Sharma wrote:
> pidhash is no longer required as all the information
> can be looked up from idr tree. Also, nr_hashed represented
> the number of pids that had been hashed. Since, nr_hashed is
> no longer relevant, it has been renamed to pid_allocated.
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> @@ -66,7 +59,7 @@ int pid_max_max = PID_MAX_LIMIT;
> struct pid_namespace init_pid_ns = {
> .kref = KREF_INIT(2),
> .idr = IDR_INIT,
> - .nr_hashed = PIDNS_HASH_ADDING,
> + .pid_allocated = PIDNS_HASH_ADDING,
> .level = 0,
> .child_reaper = &init_task,
> .user_ns = &init_user_ns,
>
Should PIDNS_HASH_ADDING be renamed too, now that the pidhash is
gone?
Not that I have any ideas for a better name. This patch looks good
to me. Feel free to add this line the next time you submit it:
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2017-09-25 13:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 12:56 [PATCH 0/4] Replace PID bitmap with IDR API implementation Gargi Sharma
2017-09-25 12:56 ` [PATCH 1/4] pid: Replace pid bitmap implementation with IDR API Gargi Sharma
2017-09-25 13:09 ` Rik van Riel
2017-09-25 14:59 ` Oleg Nesterov
2017-09-25 17:41 ` Gargi Sharma
2017-09-25 15:20 ` Oleg Nesterov
2017-09-25 17:41 ` Gargi Sharma
2017-09-25 12:56 ` [PATCH 2/4] idr: Add a function idr_get() Gargi Sharma
2017-09-25 13:20 ` Rik van Riel
2017-09-25 13:47 ` Christoph Hellwig
2017-09-25 14:12 ` Oleg Nesterov
2017-09-25 17:43 ` Gargi Sharma
2017-09-25 12:56 ` [PATCH 3/4] pid.c: Replace pidhash lookup with idr_get() Gargi Sharma
2017-09-25 13:20 ` Rik van Riel
2017-09-25 17:44 ` Gargi Sharma
2017-09-25 19:30 ` Rik van Riel
2017-09-25 12:56 ` [PATCH 4/4] pid: Remove pidhash Gargi Sharma
2017-09-25 13:48 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506347309.21121.84.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=gs051095@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=pasha.tatashin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox