From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935795AbdIYNsg (ORCPT ); Mon, 25 Sep 2017 09:48:36 -0400 Received: from shelob.surriel.com ([96.67.55.147]:51440 "EHLO shelob.surriel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934381AbdIYNsf (ORCPT ); Mon, 25 Sep 2017 09:48:35 -0400 Message-ID: <1506347309.21121.84.camel@surriel.com> Subject: Re: [PATCH 4/4] pid: Remove pidhash From: Rik van Riel To: Gargi Sharma , linux-kernel@vger.kernel.org Cc: julia.lawall@lip6.fr, akpm@linux-foundation.org, mingo@kernel.org, pasha.tatashin@oracle.com, ktkhai@virtuozzo.com, oleg@redhat.com Date: Mon, 25 Sep 2017 09:48:29 -0400 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-7ii11XQPJngGXlksHo+t" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-7ii11XQPJngGXlksHo+t Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2017-09-25 at 08:56 -0400, Gargi Sharma wrote: > pidhash is no longer required as all the information > can be looked up from idr tree. Also, nr_hashed represented > the number of pids that had been hashed. Since, nr_hashed is > no longer relevant, it has been renamed to pid_allocated. >=20 > Signed-off-by: Gargi Sharma > @@ -66,7 +59,7 @@ int pid_max_max =3D PID_MAX_LIMIT; > =C2=A0struct pid_namespace init_pid_ns =3D { > =C2=A0 .kref =3D KREF_INIT(2), > =C2=A0 .idr =3D IDR_INIT, > - .nr_hashed =3D PIDNS_HASH_ADDING, > + .pid_allocated =3D PIDNS_HASH_ADDING, > =C2=A0 .level =3D 0, > =C2=A0 .child_reaper =3D &init_task, > =C2=A0 .user_ns =3D &init_user_ns, >=20 Should PIDNS_HASH_ADDING be renamed too, now that the pidhash is gone? Not that I have any ideas for a better name. This patch looks good to me. Feel free to add this line the next time you submit it: Reviewed-by: Rik van Riel --=20 All Rights Reversed. --=-7ii11XQPJngGXlksHo+t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJZyQktAAoJEM553pKExN6DjSoIAKtcr7nxUUekaUYTJy950jzb pUOMzJBa9gZM9cDRl127P+jD+/HBno6R+SFXf+EbrmHsQ6uu/69iofkDC/83Yz6P 9cTnpk7YjQ3qPXTgFhRfC4QxcjkUUi8zf9y9oEQRAfpEvdfH+9/p+6wEgcq+N4ZG fk2pZaVBuyiBNyrJVvjMjZMFf3RT5qUbox38Dy4f5GMFeddKKu2hYijtGokf770M 6cLNmVr4nwkAbgHVE3zlKtfB658UHdY+lAsGwN72PaTmXDe3Sz0cM4cLhu5JtXXc NWd/xGHYTakcmrimjFr1ehne5ghNRSLNn79HRGU8TVQ9KEWRlE3DqiemkQ6JkOY= =DYDp -----END PGP SIGNATURE----- --=-7ii11XQPJngGXlksHo+t--