From: Joe Perches <joe@perches.com>
To: Leon Romanovsky <leonro@mellanox.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: matanb@mellanox.com, dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines
Date: Tue, 26 Sep 2017 08:05:37 -0700 [thread overview]
Message-ID: <1506438337.29089.8.camel@perches.com> (raw)
In-Reply-To: <20170926083843.GB6816@mtr-leonro.local>
On Tue, 2017-09-26 at 11:38 +0300, Leon Romanovsky wrote:
> On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote:
> > pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to
> > avoid other messages being concatenated.
[]
> Did you see it is happening?
> It is not needed after 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing continuation lines")
Not completely true, and that commit message
itself is incorrect about how KERN_CONT was
ever required or not required.
After that commit, the dmesg output will
eventually be corrected with an appended newline
for sine line format strings without them, but
the printk subsystem has to wait for another
printk to occur before inserting that newline.
The commit message bit that says:
Things get much hairier when you have
multiple threads going on and user level
reading and writing logs too
is correct. That's the actual reason that
the proposed newline additions are reasonable.
next prev parent reply other threads:[~2017-09-26 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 6:50 [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines Arvind Yadav
2017-09-26 7:07 ` Yuval Shaia
2017-09-26 8:38 ` Leon Romanovsky
2017-09-26 15:05 ` Joe Perches [this message]
2017-09-26 15:50 ` Leon Romanovsky
2017-09-26 19:11 ` Joe Perches
2017-09-27 14:20 ` Doug Ledford
2017-09-27 14:46 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506438337.29089.8.camel@perches.com \
--to=joe@perches.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox