From: Joe Perches <joe@perches.com>
To: Yuval Shaia <yuval.shaia@oracle.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: selvin.xavier@broadcom.com, dledford@redhat.com,
sean.hefty@intel.com, hal.rosenstock@gmail.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines
Date: Tue, 26 Sep 2017 08:23:07 -0700 [thread overview]
Message-ID: <1506439387.29089.10.camel@perches.com> (raw)
In-Reply-To: <20170926071920.GD5825@yuvallap>
On Tue, 2017-09-26 at 10:19 +0300, Yuval Shaia wrote:
> On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
> > pr_err() messages should end with a new-line to avoid other messages
> > being concatenated.
[]
> > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
[]
> > @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
> > if (reset) {
> > status = ocrdma_mbx_rdma_stats(dev, true);
> > if (status) {
> > - pr_err("Failed to reset stats = %d", status);
> > + pr_err("Failed to reset stats = %d\n", status);
> > goto err;
> > }
> > }
>
> While there, can you also fix line 1096 in ocrdma_hw.c?
>
> (is it too naive to expect checkptahc to catch such errors?)
Yes. It is not reasonable.
There would be way too high a false positive rate
as checkpatch could not trace whether or not there
is a printk(KERN_CONT or pr_cont after that.
next prev parent reply other threads:[~2017-09-26 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 6:51 [PATCH] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav
2017-09-26 7:19 ` Yuval Shaia
2017-09-26 7:31 ` Arvind Yadav
2017-09-26 15:23 ` Joe Perches [this message]
2017-09-27 14:20 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506439387.29089.10.camel@perches.com \
--to=joe@perches.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=selvin.xavier@broadcom.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox