From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752801AbdI0Mlt (ORCPT ); Wed, 27 Sep 2017 08:41:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49936 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbdI0Mls (ORCPT ); Wed, 27 Sep 2017 08:41:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7ADF1883C0 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com Message-ID: <1506516105.82712.0.camel@redhat.com> Subject: Re: [PATCH for-next 05/20] RDMA/hns: Add command queue support for hip08 RoCE driver From: Doug Ledford To: "Wei Hu (Xavier)" , Leon Romanovsky Cc: "Wei Hu (Xavier)" , linux-rdma@vger.kernel.org, lijun_nudt@163.com, oulijun@huawei.com, charles.chenxin@huawei.com, liuyixian@huawei.com, xushaobo2@huawei.com, zhangxiping3@huawei.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org Date: Wed, 27 Sep 2017 08:41:45 -0400 In-Reply-To: <1b8bda3b-c514-7e46-08bf-3ea50ea68096@redhat.com> References: <1504084998-64397-1-git-send-email-xavier.huwei@huawei.com> <1504084998-64397-6-git-send-email-xavier.huwei@huawei.com> <1506359213.120853.75.camel@redhat.com> <20170925171821.GQ25094@mtr-leonro.local> <1506361015.120853.81.camel@redhat.com> <59CA5261.80209@huawei.com> <81dd332d-e060-d7e3-bec9-1791511c5470@redhat.com> <9172f8c5-3dd6-a573-8e28-1b3ae4b1726b@tom.com> <1b8bda3b-c514-7e46-08bf-3ea50ea68096@redhat.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 27 Sep 2017 12:41:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-09-27 at 08:21 -0400, Doug Ledford wrote: > > And if you argee, after this patchset has been accepted we will > send a > > following up patch : > > In hns_roce_cmq_send function, replace > > usleep_range(1000, 2000); > > with the following statement: > > udelay(1); > > And if so, we can avoid using usleep_range function in > spin_lock_bh > > spin region, > > because it probally cause calltrace. > > Ok, I'm fine with that. I'll pull these in. OK, these are in my tree, thanks. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD