From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752871AbdI0NKF (ORCPT <rfc822;w@1wt.eu>);
        Wed, 27 Sep 2017 09:10:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37982 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752736AbdI0NKD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Sep 2017 09:10:03 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 423938553C
Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com
Message-ID: <1506517801.82712.8.camel@redhat.com>
Subject: Re: [PATCH 2/2] IB/uverbs: clean up INIT_UDATA() macro usage
From: Doug Ledford <dledford@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
        Matan Barak <matanb@mellanox.com>, Yishai Hadas <yishaih@mellanox.com>,
        Leon Romanovsky <leon@kernel.org>, Moses Reuben <mosesr@mellanox.com>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 27 Sep 2017 09:10:01 -0400
In-Reply-To: <20170906213521.1845893-2-arnd@arndb.de>
References: <20170906213521.1845893-1-arnd@arndb.de>
         <20170906213521.1845893-2-arnd@arndb.de>
Organization: Red Hat, Inc.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 27 Sep 2017 13:10:03 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-09-06 at 23:34 +0200, Arnd Bergmann wrote:
> After changing INIT_UDATA_BUF_OR_NULL() to an inline function,
> this does the same change to INIT_UDATA for consistency.
> I'm keeping it separate as this part is much larger and
> we wouldn't want to backport this to stable kernels if we
> ever want to address the gcc warnings by backporting the
> first patch.
> 
> Again, using an inline function gives us better type
> safety here among other issues with macros. I'm using
> u64_to_user_ptr() to convert the user pointer to simplify
> the logic rather than adding lots of new type casts.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD