From: Doug Ledford <dledford@redhat.com>
To: Colin King <colin.king@canonical.com>,
Steve Wise <swise@chelsio.com>, Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp
Date: Wed, 27 Sep 2017 09:11:26 -0400 [thread overview]
Message-ID: <1506517886.82712.9.camel@redhat.com> (raw)
In-Reply-To: <20170911114231.22893-1-colin.king@canonical.com>
On Mon, 2017-09-11 at 12:42 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> sqp is being initialised when it is being declared and then updated
> a little later on making the first initialization redundant. Clean
> this up by initializing ptr and sqp at their declaration.
>
> Cleans up warning: "warning: Value stored to 'sqp' during its
> initialization is never read"
>
> Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue
> pointer as needed on flush")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
prev parent reply other threads:[~2017-09-27 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 11:42 [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp Colin King
2017-09-11 14:28 ` Steve Wise
2017-09-27 13:11 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506517886.82712.9.camel@redhat.com \
--to=dledford@redhat.com \
--cc=colin.king@canonical.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox