From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753090AbdI0N25 (ORCPT ); Wed, 27 Sep 2017 09:28:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34784 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752924AbdI0N2y (ORCPT ); Wed, 27 Sep 2017 09:28:54 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CBC18285C8 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=eric.auger@redhat.com From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, marc.zyngier@arm.com, cdall@linaro.org, peter.maydell@linaro.org, andre.przywara@arm.com, wanghaibin.wang@huawei.com Cc: wu.wubin@huawei.com Subject: [PATCH v2 01/10] KVM: arm/arm64: vgic-its: fix return value for restore Date: Wed, 27 Sep 2017 15:28:31 +0200 Message-Id: <1506518920-18571-2-git-send-email-eric.auger@redhat.com> In-Reply-To: <1506518920-18571-1-git-send-email-eric.auger@redhat.com> References: <1506518920-18571-1-git-send-email-eric.auger@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 27 Sep 2017 13:28:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: wanghaibin This patch fix the migrate restore tables failure. The same scene, at the destination, the restore tables interface traversal guest memory, and check the dte/ite is valid or not. If all dtes/ites are invalid, we will do try next one, and the last it will take the 1 return value, but currently, it be treated as error. That's not correct. This patch try to fix this problem. Signed-off-by: wanghaibin --- need to CC stable v1 -> v2: - if (ret > 0) ret = 0 --- virt/kvm/arm/vgic/vgic-its.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c index f51c1e1..fbbc97b 100644 --- a/virt/kvm/arm/vgic/vgic-its.c +++ b/virt/kvm/arm/vgic/vgic-its.c @@ -2018,7 +2018,7 @@ static int vgic_its_restore_dte(struct vgic_its *its, u32 id, return PTR_ERR(dev); ret = vgic_its_restore_itt(its, dev); - if (ret) { + if (ret < 0) { vgic_its_free_device(its->dev->kvm, dev); return ret; } @@ -2141,7 +2141,7 @@ static int vgic_its_restore_device_tables(struct vgic_its *its) } if (ret > 0) - ret = -EINVAL; + ret = 0; return ret; } -- 2.5.5